Page MenuHomePhabricator
Feed All Stories

Jun 5 2020

epriestley closed D21307: Impose a HardpointEngine future parallelism limit.
Jun 5 2020, 7:15 PM
epriestley requested review of D21315: Substantially modernize the "arc land" workflow.
Jun 5 2020, 7:02 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21315: Substantially modernize the "arc land" workflow.
Jun 5 2020, 7:02 PM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

Just extracting a few blocks of old code for reference:

Jun 5 2020, 6:26 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I may actually make the minimum version whichever version has this fix:

Jun 5 2020, 5:39 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

Today, arc land in Mercurial does not support the "merge" land strategy.

Jun 5 2020, 2:55 PM · Mercurial, Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

I am dropping support for versions of Mercurial older than 2.1.1 (released in May, 2012). This is the first version that: (a) has phases and (b) does not exit 1 when hg pull succeeds but fetches no changes.

Jun 5 2020, 2:15 PM · Mercurial, Arcanist
epriestley moved T13380: `git push` fatals when CWD does not exist from Backlog to arc land on the Arcanist board.
Jun 5 2020, 6:16 AM · Arcanist
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

After changes connected to T13546, the git workflow now looks like this:

Jun 5 2020, 6:15 AM · Mercurial, Arcanist
epriestley requested review of D21314: Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy()".
Jun 5 2020, 12:53 AM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21314: Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy()".
Jun 5 2020, 12:52 AM · Arcanist
epriestley requested review of D21313: Provide modern config options for "arc land" configuration.
Jun 5 2020, 12:49 AM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21313: Provide modern config options for "arc land" configuration.
Jun 5 2020, 12:49 AM · Arcanist

Jun 4 2020

epriestley requested review of D21312: Add modern refs and hardpoints for buildables, builds, and build plans.
Jun 4 2020, 5:53 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21312: Add modern refs and hardpoints for buildables, builds, and build plans.
Jun 4 2020, 5:53 PM · Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 5:51 PM · Guides, Arcanist
epriestley updated the task description for T13546: Modernize the "arc land" workflow.
Jun 4 2020, 5:49 PM · Arcanist
epriestley requested review of D21311: Add "Author" and "Parent Revision" hardpoints to RevisionRefs.
Jun 4 2020, 4:54 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21311: Add "Author" and "Parent Revision" hardpoints to RevisionRefs.
Jun 4 2020, 4:53 PM · Arcanist
epriestley requested review of D21310: Support short aliases and repeatable arguments in Arcanist Workflow arguments.
Jun 4 2020, 4:51 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21310: Support short aliases and repeatable arguments in Arcanist Workflow arguments.
Jun 4 2020, 4:51 PM · Arcanist
epriestley requested review of D21309: Add a "%?" ("hint") conversion to "tsprintf()".
Jun 4 2020, 4:50 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21309: Add a "%?" ("hint") conversion to "tsprintf()".
Jun 4 2020, 4:49 PM · Arcanist
epriestley requested review of D21308: Support appending arbitrary lines to DisplayRef output.
Jun 4 2020, 4:48 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21308: Support appending arbitrary lines to DisplayRef output.
Jun 4 2020, 4:48 PM · Arcanist
epriestley requested review of D21307: Impose a HardpointEngine future parallelism limit.
Jun 4 2020, 4:46 PM
epriestley added a revision to T13546: Modernize the "arc land" workflow: D21307: Impose a HardpointEngine future parallelism limit.
Jun 4 2020, 4:45 PM · Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 4:37 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 3:39 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 12:49 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 12:48 PM · Guides, Arcanist
scp awarded T2493: Support `arc land` in stacked commits a Love token.
Jun 4 2020, 10:50 AM · Restricted Project, Arcanist
epriestley moved T2920: Modularize the pipeline for producing final commit messages from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:17 AM · Arcanist
epriestley moved T9457: arc diff crashes when trying to stash submodule diffs from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:14 AM · Arcanist
epriestley moved T9898: `git branch --contains X` has cost in the realm of O(commits * branches) from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:13 AM · Restricted Project, Restricted Project, Arcanist
epriestley moved T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:10 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley moved T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:09 AM · Mercurial, Arcanist
epriestley moved T13532: Git commit hooks may mutate commits in "arc land", discarding "Differential Revision: ..." from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:08 AM · Arcanist
epriestley moved T13547: Upgrading: Mid 2020 Changes to "arc land" from Backlog to arc land on the Arcanist board.
Jun 4 2020, 3:08 AM · Guides, Arcanist
epriestley closed T5852: arc should ignore abandoned revisions when landing as Wontfix.

After near-future changes connected to T13546 this is ripe for implementation, but I don't think it has come up again in ~6 years so I'm not sure it's actually worth improving. arc has also warned about abandoned revisions for a long time, which may have mooted this. My expectation is that the modern behavior is clear and the remedy is simple (arc land --revision 123) but I'm open to reconsidering this once the changes connected to T13546 have stabilized, if it's still an issue then.

Jun 4 2020, 3:05 AM · Restricted Project, Arcanist
epriestley closed T11535: Make it possible for arc land to disable upstream branch tracking as Wontfix.

After near-future changes connected to T13546, arc.land.onto (previously arc.land.onto.default) has higher priority than upstream branches.

Jun 4 2020, 3:01 AM · Arcanist, Restricted Project
epriestley closed T11535: Make it possible for arc land to disable upstream branch tracking, a subtask of T11362: Arcanist tries to land onto identical remote branch instead of 'master', as Wontfix.
Jun 4 2020, 3:01 AM · Arcanist, Bug Report
epriestley closed T2493: Support `arc land` in stacked commits, a subtask of T3875: Allow arc to perform cascading rebases, maybe during or after `arc land`, as Resolved.
Jun 4 2020, 2:57 AM · Prioritized, Restricted Project, Arcanist
epriestley closed T2493: Support `arc land` in stacked commits as Resolved.

Changes connected to T13546 address this, see T13547 for a preview of new behavior.

Jun 4 2020, 2:57 AM · Restricted Project, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 4 2020, 2:51 AM · Guides, Arcanist

Jun 3 2020

epriestley updated the task description for T13546: Modernize the "arc land" workflow.
Jun 3 2020, 7:30 PM · Arcanist

Jun 2 2020

epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 2 2020, 9:00 PM · Guides, Arcanist
epriestley updated the task description for T13547: Upgrading: Mid 2020 Changes to "arc land".
Jun 2 2020, 7:11 PM · Guides, Arcanist
epriestley triaged T13547: Upgrading: Mid 2020 Changes to "arc land" as Normal priority.
Jun 2 2020, 7:10 PM · Guides, Arcanist
epriestley moved T13546: Modernize the "arc land" workflow from Backlog to arc land on the Arcanist board.
Jun 2 2020, 5:13 PM · Arcanist
epriestley added a comment to T13546: Modernize the "arc land" workflow.

See PHI1013, which would like a way to specify that the branch you want to merge into might be different from the name of the branch you want to push into the remote.

Jun 2 2020, 5:10 PM · Arcanist
epriestley added a comment to T12876: Improve initial arc land experience when destination repo is empty.

I think the general shape of this is:

Jun 2 2020, 4:58 PM · Arcanist
epriestley committed rARC7378e2baad69: Remove special casing of "arc --version" (authored by epriestley).
Remove special casing of "arc --version"
Jun 2 2020, 3:58 PM
epriestley closed D21306: Remove special casing of "arc --version".
Jun 2 2020, 3:58 PM
epriestley requested review of D21306: Remove special casing of "arc --version".
Jun 2 2020, 3:55 PM

May 31 2020

epriestley updated the task description for T13546: Modernize the "arc land" workflow.
May 31 2020, 12:04 AM · Arcanist

May 30 2020

epriestley triaged T13546: Modernize the "arc land" workflow as Normal priority.
May 30 2020, 11:58 PM · Arcanist
epriestley requested review of D21305: Merge the "--raw" and "--raw-command" flags to "arc diff" into "--raw <path>".
May 30 2020, 11:16 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21305: Merge the "--raw" and "--raw-command" flags to "arc diff" into "--raw <path>".
May 30 2020, 11:16 PM · Arcanist
epriestley updated the task description for T13545: Upgrading: Mid 2020 Changes to "arc diff".
May 30 2020, 11:11 PM · Arcanist, Guides
epriestley triaged T13545: Upgrading: Mid 2020 Changes to "arc diff" as Low priority.
May 30 2020, 11:05 PM · Arcanist, Guides
epriestley requested review of D21304: Remove "--amend-all", "--no-amend", and "--amend-autofixes" from "arc diff".
May 30 2020, 10:56 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21304: Remove "--amend-all", "--no-amend", and "--amend-autofixes" from "arc diff".
May 30 2020, 10:55 PM · Arcanist
sshannin added a comment to D21295: Correct a prose diff behavior when prose pieces include newlines.

thanks. I can confirm the change lets the daemon finish the task and renders a reasonable diff.

May 30 2020, 10:51 PM
epriestley requested review of D21303: Remove "--ignore-unsound-tests" from "arc diff".
May 30 2020, 10:50 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21303: Remove "--ignore-unsound-tests" from "arc diff".
May 30 2020, 10:49 PM · Arcanist
epriestley requested review of D21302: Remove "--apply-patches" and "--never-apply-patches" from "arc diff".
May 30 2020, 10:48 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21302: Remove "--apply-patches" and "--never-apply-patches" from "arc diff".
May 30 2020, 10:47 PM · Arcanist
epriestley requested review of D21301: Remove the "--less-context" flag from "arc diff".
May 30 2020, 10:43 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21301: Remove the "--less-context" flag from "arc diff".
May 30 2020, 10:42 PM · Arcanist
epriestley requested review of D21300: Remove "--encoding" flag from "arc diff".
May 30 2020, 10:30 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21300: Remove "--encoding" flag from "arc diff".
May 30 2020, 10:30 PM · Arcanist
epriestley requested review of D21299: Remove "haveUncommittedChanges" property from "arc diff".
May 30 2020, 10:26 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21299: Remove "haveUncommittedChanges" property from "arc diff".
May 30 2020, 10:26 PM · Arcanist
epriestley added a comment to T13544: Modernize the "arc diff" workflow.

arc diff has a lot of code to deal with handling untracked or uncommitted changes in the working copy. The major motivations for arc caring about this are:

May 30 2020, 10:23 PM · Arcanist
epriestley updated the summary of D21297: Remove lint and unit excuses and "--advice" and "--excuse" flags from "arc diff".
May 30 2020, 9:54 PM
epriestley requested review of D21298: Remove "--lintall" and "--only-new" flags to "arc diff".
May 30 2020, 9:54 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21298: Remove "--lintall" and "--only-new" flags to "arc diff".
May 30 2020, 9:54 PM · Arcanist
epriestley requested review of D21297: Remove lint and unit excuses and "--advice" and "--excuse" flags from "arc diff".
May 30 2020, 9:48 PM
epriestley added a subtask for T13490: Upgrade all "classic" Arcanist workflows to Toolsets: T13544: Modernize the "arc diff" workflow.
May 30 2020, 9:47 PM · Arcanist
epriestley added a parent task for T13544: Modernize the "arc diff" workflow: T13490: Upgrade all "classic" Arcanist workflows to Toolsets.
May 30 2020, 9:47 PM · Arcanist
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21297: Remove lint and unit excuses and "--advice" and "--excuse" flags from "arc diff".
May 30 2020, 9:47 PM · Arcanist
epriestley requested review of D21296: Remove "--use-commit-message/-C" from "arc diff".
May 30 2020, 9:34 PM
epriestley added a revision to T13544: Modernize the "arc diff" workflow: D21296: Remove "--use-commit-message/-C" from "arc diff".
May 30 2020, 9:34 PM · Arcanist
epriestley added a comment to T13544: Modernize the "arc diff" workflow.

I'm not sure --use-commit-message has any real use cases.

May 30 2020, 9:28 PM · Arcanist
epriestley triaged T13544: Modernize the "arc diff" workflow as Normal priority.
May 30 2020, 9:26 PM · Arcanist
epriestley committed rP36075f6ce525: Correct a prose diff behavior when prose pieces include newlines (authored by epriestley).
Correct a prose diff behavior when prose pieces include newlines
May 30 2020, 9:11 PM
epriestley closed D21295: Correct a prose diff behavior when prose pieces include newlines.
May 30 2020, 9:11 PM
epriestley requested review of D21295: Correct a prose diff behavior when prose pieces include newlines.
May 30 2020, 9:05 PM
epriestley edited the content of Changelog.
May 30 2020, 12:00 PM
epriestley created an object: 2020 Week 21 (Very Late May).
May 30 2020, 11:56 AM
epriestley committed rARCd1c07b4d2634: (stable) Promote 2020 Week 21 (authored by epriestley).
(stable) Promote 2020 Week 21
May 30 2020, 11:56 AM
epriestley committed rPb9d52f38ddad: (stable) Promote 2020 Week 21 (authored by epriestley).
(stable) Promote 2020 Week 21
May 30 2020, 11:56 AM
epriestley committed rARC0da1a2e17d92: Allow PhutilArrayCheck to accept a list of objects as a context (authored by epriestley).
Allow PhutilArrayCheck to accept a list of objects as a context
May 30 2020, 10:37 AM
epriestley closed D21294: Allow PhutilArrayCheck to accept a list of objects as a context.
May 30 2020, 10:37 AM

May 28 2020

20after4 added a comment to T10915: Allow story points to just be task count.

I think that this is something we(Wikimedia) can patch downstream in our fork, I don't think there is anything further to add to this upstream discussion.

May 28 2020, 6:27 PM · Restricted Project, Feature Request
epriestley requested review of D21294: Allow PhutilArrayCheck to accept a list of objects as a context.
May 28 2020, 6:09 PM
epriestley added a comment to T13542: Rebalance Phacility instances into a private subnet.

Piledriver would also benefit from having some functional equivalent of destroying an Almanac resource. This can be implemented as a piledriver.destroyed property, but a formal disabled state would be cleaner. PHI1331 is vaguely related.

May 28 2020, 5:53 PM · Phacility
mbinder added a comment to T10915: Allow story points to just be task count.

Bumping again simply because this has come up a few times this month. Teams I work with want to use a WIP feature, but don't use the current implementation because it tracks points instead of tasks. Reviewing the rest of the comments in this thread, all of it remains relevant to those use-cases.

May 28 2020, 5:45 PM · Restricted Project, Feature Request
SirensOfTitan edited the content of Community Resources.
May 28 2020, 4:13 PM