Page MenuHomePhabricator

Remove "--use-commit-message/-C" from "arc diff"
ClosedPublic

Authored by epriestley on May 30 2020, 9:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 5:22 PM
Unknown Object (File)
Mon, Nov 18, 12:40 PM
Unknown Object (File)
Thu, Nov 14, 9:58 AM
Unknown Object (File)
Sun, Nov 10, 6:47 AM
Unknown Object (File)
Tue, Nov 5, 8:35 PM
Unknown Object (File)
Oct 23 2024, 6:06 AM
Unknown Object (File)
Oct 16 2024, 8:25 AM
Unknown Object (File)
Oct 9 2024, 7:02 PM
Subscribers
None

Details

Summary

Ref T13544. This flag was introduced in D1385 (2012) as part of a workflow which no longer exists. I can't recall anyone ever reporting an issue which involves its use and believe it is likely unused. It's not obvious to me why someone would use it in modern "arc".

(The same goal can be accomplished with "--message-file ...", although this requires more steps.)

Test Plan

Grepped for "use-commit-message" and "getCommitMessageFromCommit", ran "arc diff".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable