Page MenuHomePhabricator

Remove "--use-commit-message/-C" from "arc diff"
ClosedPublic

Authored by epriestley on May 30 2020, 9:34 PM.

Details

Summary

Ref T13544. This flag was introduced in D1385 (2012) as part of a workflow which no longer exists. I can't recall anyone ever reporting an issue which involves its use and believe it is likely unused. It's not obvious to me why someone would use it in modern "arc".

(The same goal can be accomplished with "--message-file ...", although this requires more steps.)

Test Plan

Grepped for "use-commit-message" and "getCommitMessageFromCommit", ran "arc diff".

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 30 2020, 9:34 PM
epriestley requested review of this revision.May 30 2020, 9:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jun 5, 8:22 PM
This revision was automatically updated to reflect the committed changes.