Page MenuHomePhabricator

Remove "--apply-patches" and "--never-apply-patches" from "arc diff"
Needs ReviewPublic

Authored by epriestley on May 30 2020, 10:47 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T13544: Modernize the "arc diff" workflow
Summary

Ref T13544. These are passthrough flags that control the behavior of the "arc lint" subprocess.

I suspect all use cases of "--apply-patches" are better served by a prompt default via "arc prompts".

I suspect all use cases of "--never-apply-patches" are better served by either using prompt defaults or by using "--nolint", which accomplishes the same goal ("ignore lint") much faster. If you want to look at lint and make a nuanced decision about what to act on, you can use "arc lint".

Test Plan

Searched for "apply-patches" and "never-apply-patches", created this revision.

Diff Detail

Repository
rARC Arcanist
Branch
xdiff7
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24541
Build 33823: Run Core Tests
Build 33822: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2020, 10:47 PM
epriestley requested review of this revision.May 30 2020, 10:48 PM