Page MenuHomePhabricator

Remove "--apply-patches" and "--never-apply-patches" from "arc diff"
Needs ReviewPublic

Authored by epriestley on May 30 2020, 10:47 PM.
Tags
None
Referenced Files
F18621047: D21302.id.diff
Mon, Sep 15, 6:56 AM
F18618023: D21302.diff
Sun, Sep 14, 10:58 PM
F18337641: D21302.diff
Aug 25 2025, 6:26 PM
F18187751: D21302.id50719.diff
Aug 16 2025, 8:11 PM
F18104016: D21302.id.diff
Aug 10 2025, 9:15 AM
F18102951: D21302.diff
Aug 10 2025, 12:29 AM
F18101137: D21302.diff
Aug 9 2025, 12:21 PM
F18086670: D21302.diff
Aug 5 2025, 11:16 PM
Subscribers
None
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T13544: Modernize the "arc diff" workflow
Summary

Ref T13544. These are passthrough flags that control the behavior of the "arc lint" subprocess.

I suspect all use cases of "--apply-patches" are better served by a prompt default via "arc prompts".

I suspect all use cases of "--never-apply-patches" are better served by either using prompt defaults or by using "--nolint", which accomplishes the same goal ("ignore lint") much faster. If you want to look at lint and make a nuanced decision about what to act on, you can use "arc lint".

Test Plan

Searched for "apply-patches" and "never-apply-patches", created this revision.

Diff Detail

Repository
rARC Arcanist
Branch
xdiff7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24541
Build 33823: Run Core Tests
Build 33822: arc lint + arc unit