Remove "--amend-all", "--no-amend", and "--amend-autofixes" from "arc diff"
Needs ReviewPublic
Actions

Authored by epriestley on May 30 2020, 10:55 PM.

Tags

None

Referenced Files

	F13079750: D21304.diff
	Wed, Apr 24, 1:50 AM

	Unknown Object (File)
	Sun, Apr 21, 3:54 PM

	Unknown Object (File)
	Wed, Apr 17, 2:59 PM

	Unknown Object (File)
	Thu, Apr 11, 7:10 AM

	Unknown Object (File)
	Mon, Apr 8, 6:17 AM

	Unknown Object (File)
	Mar 3 2024, 2:00 PM

	Unknown Object (File)
	Feb 13 2024, 10:40 PM

	Unknown Object (File)
	Feb 2 2024, 9:24 AM

View All 52 Files

Subscribers

None

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None
Maniphest Tasks: T13544: Modernize the "arc diff" workflow

Summary

Ref T13544. The "yes" and "no" flags should become prompt defaults. I'd like to simplify the concept of autofixes away.

Test Plan

Grepped for "amend-all", "no-amend", and "amend-autofixes". Created this revision.

Diff Detail

Repository

rARC Arcanist

Branch

xdiff9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24543
Build 33827: Run Core Tests
Build 33826: arc lint + arc unit

Event Timeline

epriestley created this revision.May 30 2020, 10:55 PM

Harbormaster completed remote builds in B24543: Diff 50721.May 30 2020, 10:56 PM

epriestley requested review of this revision.May 30 2020, 10:56 PM

epriestley added a parent revision: D21303: Remove "--ignore-unsound-tests" from "arc diff".Jun 3 2020, 7:48 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

24 lines

Diff 50721

View Options

src/workflow/ArcanistDiffWorkflow.php

Remove "--amend-all", "--no-amend", and "--amend-autofixes" from "arc diff"Needs ReviewPublicActions