See PHI1723. A user installed a Git commit-msg (probably?) or pre-commit hook (maybe?) which mutated the commit generated by arc land, discarding "Differential Revision: ...".
We can git commit --no-verify instead to skip hooks, but there are some legitimate reasons to have hooks. Possible ways forward:
- Do nothing, users are doing this on purpose to some degree and just going along with it is the best match for user intent.
- Just --no-verify and skip hooks.
- --no-verify first, grab the hash, amend -C HEAD, check if the hash changed, warn the user if it did.
- If pre-commit can not mutate the commit: commit, grab the message, compare the message, warn if it changed (and/or is missing "Differential Revision: ...").