Page MenuHomePhabricator

Merge the "--raw" and "--raw-command" flags to "arc diff" into "--raw <path>"
Needs ReviewPublic

Authored by epriestley on May 30 2020, 11:16 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T13544: Modernize the "arc diff" workflow
Summary

Ref T13544. These flags can reasonably be combined into a single flag, and I'm also not entirely comfortable with executing arbitrary subprocesses directly from CLI arguments in modern arc. There are other ways to accomplish this goal, but I'd like to move toward fewer sources of arbitrary command execution.

Test Plan

Created this revision with git show | arc diff --raw.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 24544
Build 33828: arc lint + arc unit

Event Timeline

epriestley requested review of this revision.May 30 2020, 11:16 PM
epriestley created this revision.