Page MenuHomePhabricator

Remove "--lintall" and "--only-new" flags to "arc diff"
ClosedPublic

Authored by epriestley on May 30 2020, 9:54 PM.

Details

Summary

Ref T13544. These flags change the behavior of the "arc lint" subprocess.

I believe there is no reason to ever use "arc diff --lintall". If you want to find extra warnings to fix, you can use "arc lint --lintall" to express this intent.

Use of "arc diff --only-new" almost certainly means your linters are raising messages at "error" severity which should instead be raised at "warning" severity. If you only care about fixing a particular type of error in changed code, it should be raised as a "warning". The correct remedy is to adjust the severity, not use "--only-new", which is a very broad, slow, complicated hammer.

Test Plan

Searched for "lintall" and "only-new" in this workflow. These flags still exist in "arc lint", but may be changed in the future. Generated this change.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.May 30 2020, 9:54 PM
epriestley requested review of this revision.May 30 2020, 9:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Fri, Jun 5, 8:24 PM
This revision was automatically updated to reflect the committed changes.