Page MenuHomePhabricator

Remove "--lintall" and "--only-new" flags to "arc diff"
ClosedPublic

Authored by epriestley on May 30 2020, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 10:07 PM
Unknown Object (File)
Fri, Mar 15, 7:40 PM
Unknown Object (File)
Sun, Mar 3, 2:00 PM
Unknown Object (File)
Feb 21 2024, 5:22 PM
Unknown Object (File)
Feb 14 2024, 2:56 PM
Unknown Object (File)
Feb 11 2024, 4:58 AM
Unknown Object (File)
Feb 7 2024, 10:19 PM
Unknown Object (File)
Feb 2 2024, 9:23 AM
Subscribers
None

Details

Summary

Ref T13544. These flags change the behavior of the "arc lint" subprocess.

I believe there is no reason to ever use "arc diff --lintall". If you want to find extra warnings to fix, you can use "arc lint --lintall" to express this intent.

Use of "arc diff --only-new" almost certainly means your linters are raising messages at "error" severity which should instead be raised at "warning" severity. If you only care about fixing a particular type of error in changed code, it should be raised as a "warning". The correct remedy is to adjust the severity, not use "--only-new", which is a very broad, slow, complicated hammer.

Test Plan

Searched for "lintall" and "only-new" in this workflow. These flags still exist in "arc lint", but may be changed in the future. Generated this change.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 8:24 PM
This revision was automatically updated to reflect the committed changes.