Page MenuHomePhabricator

arc should ignore abandoned revisions when landing
Closed, WontfixPublic

Description

Scenario:

  1. I branch and start coding.
  2. I arc diff.
  3. For whatever reason, I decide I want to start with a fresh differential, so I abandon the existing one and arc diff again.
  4. Down the road, I go to arc land and arc tells me that it doesn't know which revision I mean, and shows me both the abandoned and the current revision.

It's unlikely that someone will want to land an abandoned revision (and frankly, arc should warn in this case). In case of ambiguity, arc should not consider abandoned revisions.

Event Timeline

lexelby raised the priority of this task from to Needs Triage.
lexelby updated the task description. (Show Details)
lexelby added a subscriber: lexelby.
epriestley added a project: Arcanist.
epriestley added a subscriber: epriestley.

I think the desired behavior is a reasonable one to implement, although we should possibly print out a message that we're ignoring it and continue to make the operation a bit less magical.

eadler added a project: Restricted Project.Jun 17 2016, 7:06 AM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jun 17 2016, 7:09 AM
eadler moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Jul 4 2016, 9:05 PM
epriestley claimed this task.

After near-future changes connected to T13546 this is ripe for implementation, but I don't think it has come up again in ~6 years so I'm not sure it's actually worth improving. arc has also warned about abandoned revisions for a long time, which may have mooted this. My expectation is that the modern behavior is clear and the remedy is simple (arc land --revision 123) but I'm open to reconsidering this once the changes connected to T13546 have stabilized, if it's still an issue then.