Support appending arbitrary lines to DisplayRef output
ClosedPublic
Actions

Authored by epriestley on Jun 4 2020, 4:48 PM.

Tags

None

Referenced Files

	F17947686: D21308.id.diff
	Thu, Jul 31, 5:58 PM

	F17928342: D21308.diff
	Wed, Jul 30, 4:03 PM

	F17862279: D21308.diff
	Sun, Jul 27, 11:44 PM

	Unknown Object (File)
	Jun 5 2025, 4:56 PM

	Unknown Object (File)
	May 9 2025, 4:50 PM

	Unknown Object (File)
	Apr 13 2025, 10:22 AM

	Unknown Object (File)
	Apr 8 2025, 8:33 AM

	Unknown Object (File)
	Apr 6 2025, 7:38 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARC0e8247400713: Support appending arbitrary lines to DisplayRef output

Summary

Ref T13546. Several substeps in the new "arc land" flow benefit from this. For example:

When prompting "land revisions you don't own?", it's used to show authors.
When prompting "land revisions in the wrong state?", it's used to show the current states.

Test Plan

Ran future "arc land" workflows, got relevant contextual information via this mechanism.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 4 2020, 4:48 PM

Harbormaster completed remote builds in B24548: Diff 50726.Jun 4 2020, 4:48 PM

epriestley requested review of this revision.Jun 4 2020, 4:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 7:22 PM

Closed by commit rARC0e8247400713: Support appending arbitrary lines to DisplayRef output (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC0e8247400713: Support appending arbitrary lines to DisplayRef output.

Revision Contents
Changeset List

Path

Size

src/

ref/

ArcanistDisplayRef.php

10 lines

Diff 50735

View Options

src/ref/ArcanistDisplayRef.php

Support appending arbitrary lines to DisplayRef outputClosedPublicActions