Remove "--ignore-unsound-tests" from "arc diff"
ClosedPublic
Actions

Authored by epriestley on May 30 2020, 10:49 PM.

Tags

None

Referenced Files

	F18339467: D21303.diff
	Mon, Aug 25, 9:30 PM

	F18339016: D21303.diff
	Mon, Aug 25, 9:06 PM

	F18338497: D21303.diff
	Mon, Aug 25, 8:21 PM

	F18338343: D21303.diff
	Mon, Aug 25, 7:56 PM

	F18338112: D21303.diff
	Mon, Aug 25, 7:40 PM

	F18337934: D21303.diff
	Mon, Aug 25, 7:15 PM

	F18337687: D21303.diff
	Mon, Aug 25, 6:31 PM

	F18337502: D21303.diff
	Mon, Aug 25, 6:12 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13544: Modernize the "arc diff" workflow
Commits: rARC86471fc0feac: Remove "--ignore-unsound-tests" from "arc diff"

Summary

Ref T13544. This flag only disables a warning and should be a prompt default, not a flag.

Test Plan

Grepped for "ignore-unsound-tests", created this revision.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 30 2020, 10:49 PM

Harbormaster completed remote builds in B24542: Diff 50720.May 30 2020, 10:50 PM

epriestley requested review of this revision.May 30 2020, 10:50 PM

epriestley added a child revision: D21304: Remove "--amend-all", "--no-amend", and "--amend-autofixes" from "arc diff".Jun 3 2020, 7:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:58 PM

Closed by commit rARC86471fc0feac: Remove "--ignore-unsound-tests" from "arc diff" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARC86471fc0feac: Remove "--ignore-unsound-tests" from "arc diff".

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistDiffWorkflow.php

31 lines

Diff 50778

View Options

src/workflow/ArcanistDiffWorkflow.php

Remove "--ignore-unsound-tests" from "arc diff"ClosedPublicActions