Page MenuHomePhabricator

Impose a HardpointEngine future parallelism limit
ClosedPublic

Authored by epriestley on Jun 4 2020, 4:45 PM.

Details

Summary

Ref T13546. If we try to resolve several hundred hardpoint queries which execute subprocesses, we can currently hit system limits.

For now, limit resolution to 32 simultaneous futures. In the future, this should switch to FuturePool and possibly become more nuanced.

Test Plan

In a future change, ran arc land --into-empty ... to land thousands of commits. Before change, got a "proc_open()" error when launching too many simultaneous subprocesses. After change, this "worked".

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 4 2020, 4:45 PM
epriestley requested review of this revision.Jun 4 2020, 4:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 7:15 PM
This revision was automatically updated to reflect the committed changes.