Impose a HardpointEngine future parallelism limit
ClosedPublic
Actions

Authored by epriestley on Jun 4 2020, 4:45 PM.

Details

Reviewers: None
Maniphest Tasks: T13546: Modernize the "arc land" workflow
Commits: rARCfc3974ed70c6: Impose a HardpointEngine future parallelism limit

Summary

Ref T13546. If we try to resolve several hundred hardpoint queries which execute subprocesses, we can currently hit system limits.

For now, limit resolution to 32 simultaneous futures. In the future, this should switch to FuturePool and possibly become more nuanced.

Test Plan

In a future change, ran arc land --into-empty ... to land thousands of commits. Before change, got a "proc_open()" error when launching too many simultaneous subprocesses. After change, this "worked".

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 4 2020, 4:45 PM

Harbormaster completed remote builds in B24547: Diff 50725.Jun 4 2020, 4:46 PM

epriestley requested review of this revision.Jun 4 2020, 4:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 7:15 PM

Closed by commit rARCfc3974ed70c6: Impose a HardpointEngine future parallelism limit (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCfc3974ed70c6: Impose a HardpointEngine future parallelism limit.

Revision Contents
Changeset List

Path

Size

src/

hardpoint/

ArcanistHardpointEngine.php

3 lines

Diff 50734

View Options

src/hardpoint/ArcanistHardpointEngine.php

Impose a HardpointEngine future parallelism limitClosedPublicActions