Page MenuHomePhabricator

Impose a HardpointEngine future parallelism limit
ClosedPublic

Authored by epriestley on Jun 4 2020, 4:45 PM.
Tags
None
Referenced Files
F15464434: D21307.id50734.diff
Wed, Apr 2, 9:30 AM
F15461624: D21307.id50725.diff
Tue, Apr 1, 9:36 AM
F15445169: D21307.id.diff
Thu, Mar 27, 12:41 PM
F15438273: D21307.id.diff
Tue, Mar 25, 11:55 PM
F15433764: D21307.diff
Tue, Mar 25, 12:34 AM
F15421487: D21307.id.diff
Sat, Mar 22, 12:14 AM
F15399966: D21307.id50725.diff
Mon, Mar 17, 8:50 AM
F15380002: D21307.diff
Fri, Mar 14, 12:46 AM
Subscribers
None

Details

Summary

Ref T13546. If we try to resolve several hundred hardpoint queries which execute subprocesses, we can currently hit system limits.

For now, limit resolution to 32 simultaneous futures. In the future, this should switch to FuturePool and possibly become more nuanced.

Test Plan

In a future change, ran arc land --into-empty ... to land thousands of commits. Before change, got a "proc_open()" error when launching too many simultaneous subprocesses. After change, this "worked".

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Jun 5 2020, 7:15 PM
This revision was automatically updated to reflect the committed changes.