Page MenuHomePhabricator

Introduce "RepositoryLocalState", a modern version of "requireCleanWorkingCopy()"
ClosedPublic

Authored by epriestley on Jun 5 2020, 12:52 AM.

Details

Summary

Ref T13546. Introduces a more structured construct for saving and restoring local repository state.

This is similar to old behavior, except that:

  • "arc.autostash" is no longer respected;
  • untracked changes are stashed; and
  • we do not offer to amend.
Test Plan

In future changes, saved and restored various permutations of local state.

Diff Detail

Repository
rARC Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 5 2020, 12:52 AM
epriestley requested review of this revision.Jun 5 2020, 12:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 8 2020, 10:40 PM
This revision was automatically updated to reflect the committed changes.