See PHI954. The "support pact members" cache is currently updated only when you actually click "Support", but this is often silly and unintuitive.

Aha! This user very cleverly added noreply@admin.phacility.com to their user account before they were disabled.

I deployed that last round of things to secure. Not totally confident I got everything, but hopefully we're in better shape now.

The change above seems to have worked around things, I'll leave this open until we can confirm that PHP 7.3.6 or some later version fixes the underlying issue.

uhoh looks like I'm a dum dum

This is doing somewhat better now, but I've still seen:

If this table is retained, there's a mystery meat "branch" icon meaning "default branch" in the leftmost column. This should get a label/tip.

The shallow <hash> frames can not advertise capabilities.

Here's what goes over the wire:

To reproduce this, you can:

To reproduce the first issue, do this:

D20573 will fix this, but perhaps not in the most graceful way possible.

I applied this change to 20180208.maniphest.02.populate.php:

Meow Meow

See also PHI1275. Now that Phriction supports relative references in [[ ... ]] syntax, moves should be able to modify those references.

I'm just going to close this in the hope it fades quietly into the night now that it has been "fixed".

D20563 probably fixes mail. I don't think (?) it will fix notifications but haven't hunted that down yet.

This likely affects other similar dialogs. The fix is to duct-tape something in Quicksand to something in the "click an area to click a link" behavior, most likely.

The changelog for PHP 7.3.6 mentions "Fixed possible crashes, because of inconsistent PCRE cache and opcache SHM reset." which might be relevant, but no bug link so who knows.

A sort of broad issue here is that Herald sometimes knows (or could know, or could guess, or maybe could speculate) that a rule won't do what you expect, but it doesn't tell you.

I think this is about as good as we're going to get, and we've only taken a very small step toward the precipice of a self-aware Herald that hates humankind.

KDE appears to be moving to GitLab (see: https://gitlab.com/gitlab-org/gitlab-ce/issues/53206) and we haven't seen this request from other installs, so I'm just going to close this out.

I think the modern answer here is "use Webhooks". They may not do everything you want if you're writing a chat bot (notably, they intentionally do not currently provide a human-readable text representation of transactions) but there generally suitable for publishing changes to Phabricator objects into a remote system and will produce a program with generally reasonable behaviors and no weird demons lurking under the surface.

Here's a more concise test:

Running the thing on my ubuntu exists with 0...

$ vi --version
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Apr 10 2018 21:31:58)
Included patches: 1-1453
.....
.....
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -Wdate-time  -g -O2 -fdebug-prefix-map=/build/vim-NQEcoP/vim-8.0.1453=. -fstack-protector-strong -Wformat -Werror=format-security -DTINY_VIMRC -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o vim    -lSM -lICE -lXpm -lXt -lX11 -lXdmcp -lSM -lICE  -lm -ltinfo  -lselinux -lacl -lattr -ldl

In T4752#177071, @cspeckmim wrote:

setfacl -Rdm u:phab-phd:rw /var/local/phabricator/filestore
setfacl -Rm u:phab-phd:rw /var/local/phabricator/filestore

I built my PHP from source in T13232 so this is presumably not a Homebrew issue.