Page MenuHomePhabricator

Arc Lint - Severity configuration behaves differently for different linters
Open, Needs TriagePublic

Description

In the user guide for configuring lint rule severity it indicates that

"linters": {
  "sample": {
    "type": "pep8",
    "severity": {
      "E221": "disabled",
      "E401": "warning"
    }
  }
}

Is the correct way to configure the severities of a rule, and this works for the pep8 linter.

However when configuring the text linter,

"text": {
      "type": "text",
      "severity": {
        "TXT3": "disabled",
        "TXT5": "disabled"
      }
}

does not work, but

"text": {
      "type": "text",
      "severity": {
        "3": "disabled",
        "5": "disabled"
      }
    }

does.

I was wondering if we could either fix the documentation for the linter to indicate that the behavior differs for the pep8 inter, vs the text linter vs others? Is there a consistent standard for severity labels that should be being used?

Version info

arcanist 80c8ac6c39b0ac1aca35356483e49c444418e826 (10 Aug 2016)
libphutil 84b0feab42206c0d53560f4e340fb05075fed365 (19 Mar 2016)

Revisions and Commits