Please follow the instructions in Contributing Bug Reports. This is not a valid report without version information and step by step reproduction information.

In T11517#191349, @chad wrote:

Please follow the instructions in Contributing Bug Reports. This is not a valid report without version information and step by step reproduction information.

updated

@chad could u take a look again

See Planning for timelines on how we work. If this issue is urgent and blocking your company, see Support Resources for prioritization options.

Can you post your arclint file

You are going to have to post more information. I am able to correctly see the error you posted following these steps.

mkdir lolgo && cd lolgo
git init

cat >> .arclint << EOF
{
    "linters": {
        "golint": {
            "include": [
                "(\\.go$)"
            ],
            "type": "golint"
        }
     }
}
EOF

cat >> test.go<< EOF
package test

var (
	Test = 47
)
EOF
git add --all

now run arc lint and see the expected output.

14:32 $ arc lint
>>> Lint for test.go:


   Advice  (GOLINT) GOLINT
    Exported var Test should have comment or be unexported

               1 package test
               2 
               3 var (
    >>>        4     Test = 47
               5 )
               6 
 OKAY  No lint warnings.

I imagine you have something suppressing this warning in your configuration and it's not an issue with arcanist. This is using version c7bacac2b21ca01afa1dee0acf64df3ce047c28f of golint.

If you can provide steps to reproduce i'll fix this otherwise I think this one can be closed out as an environment issue.

In T11517#192332, @michaeljs1990 wrote:

I've just tried to reproduce again, seems my steps cannot reproduce it.
I couldn't find out a good way to reproduce this bug.
Here is what I found :
when I change my existing code (removing the comment of an exported variable or method), arc lint at root git directory doesn't trigger the ADVICE
however arc lint xxx/xxx.go could trigger the lint ADVICE

And I tried to copy the same code to try to reproduce this, it works perfectly with arc lint at root git directory.
BTW, I am using some extension, https://github.com/zerodiff/traphic

Thank you a lot for looking into this

In T11517#192337, @rayzyar wrote:

In T11517#192332, @michaeljs1990 wrote:

I've just tried to reproduce again, seems my steps cannot reproduce it.
I couldn't find out a good way to reproduce this bug.
Here is what I found :
when I change my existing code (removing the comment of an exported variable or method), arc lint at root git directory doesn't trigger the ADVICE
however arc lint xxx/xxx.go could trigger the lint ADVICE

And I tried to copy the same code to try to reproduce this, it works perfectly with arc lint at root git directory.
BTW, I am using some extension, https://github.com/zerodiff/traphic

Thank you a lot for looking into this

I'll try again without loading that extension
update:
seems traphic is not affecting this

seems this is due to I didn't add the --lintall option,
the change is one line removal (existing file at the base commit)
thus it's considered as not concerned, but it is concerned actually because I didn't remove the entire function