silverskysoft, did you ever find a solution to this? I seem to be having the same issue.

The number of direct invocations of Editors in the codebase is decreasing over time, reducing the value of building this.

This got split out in to a separate tab eventually, and I think is generally in reasonable shape.

This hasn't caused any issues yet and we have no plans to show "stuff you're subscribed to".

Haha, okay. Let's just add a link to the transcript.

I guess the short of it is, I have rules to allow pushes, instead of rules to block pushes:

I deployed the sbuild and saux tiers after this, and they've been running in production for some time.

Ah, your underlying issue is difficulty understanding why pushes are rejected?

Should we maybe have the dragon also put a link to the relevant herald transcript?

T6281 is an older task discussing a possible deadlock under concurrency conditions in custom field reindexing. I think the versioning / locking approach above is probably the cleanest approach to resolving that, as well.

This has been in production for quite a while.

I think the revised version of arc land is about as good as we're likely to get. The new documentation is more clear, and the land operation no longer touches any local branches until the last second (or ever, with --hold), behavior is generally better, we restore the starting state if we fail, and the new output is more clear about what arc land is doing.

Two aspects here, one or both of which may already be partially or fully implemented:

Thanks for thinking through all of these! Let me know if there is anything I can help with.

First: HeraldTestConsoleController is currently a big mess with a huge instanceof block.

This feature request doesn't have a use case, which we now require. See Contributing Feature Requests and Describing Root Problems.

Fund is a prototype. See User Guide: Prototype Applications.

I'm just going to close this out since I think it's mostly superseded by T5307, which discusses this and other actions which would be nice to take with query result sets.

apparently I was on drugs and I thought that archanist and libphutil should be inside phabricator... moved one folder up and it works

Out pf curiosity, why not use the ... syntax instead of copy-pasting the full URL?

The reason we'd rather have it on the same line is because most hg clients (including Phabricator's Diffusion, but more importantly our local TortoiseHg clients) only show the first line of any commit in the pushlog. For us to get to the revision number would require an extra action. We generally try to keep our commit messages to one line for this reason. Additionally this was something that was difficult for us to figure out as it is inconsistent with the rest of the linking functionality explained in T5132.

We've added a linter with this fix to our library of arcanist "extras" (https://github.com/metno/arcanist-support). Also updated the install information for cpplint, as discussed in T9957.

I would also really love this feature. In jenkins, we need to create jobs for new branches (e. g. release branch > release job). Now we are using additional commit hooks, but I would like to integrate this into Phabricator. Is there any technical issue why this is not implemented or is it JUST the time issue?

Yes, but I have some hesitance around adding "search for a string in another string" fields without building better infrastructure first. There's some discussion in D14411#161139.

Ok, got it. Do you think it's reasonable to search using a package name?

We don't check that the path actually exists -- you might be searching for a deleted path that used to exist, or the repository might have a million branches and it only exists on one, and you might have a thousand different repositories too.

You are right for the cases you described. But the case I mentinoed is that /src/infrastructure/PhabricatorEditor.php doesn't exist in both Arcanist and libutil.

That result looks correct to me -- if a package includes "/", that means it includes everything under "/" too. So if you search for /x/y/z.cpp, any package that owns /, /x/, /x/y/ or /x/y/z.cpp will be returned, since any package owning a parent also owns the path itself.

Thanks for the workaround!

In T9967#148569, @epriestley wrote:

Do you have the public key (or the private key), or do you just know which user has a compromised key but not know which key is compromised?

That is, which of these commands would you be able to run if they were available?

./bin/auth revoke-public-key /path/to/compromised_public_key.pub
./bin/auth revoke-private-key /path/to/compromised_private_key.key
./bin/auth revoke-all-keys-for-user username

In T9964#148566, @epriestley wrote:

I can't reproduce that. Here's a search using "Path", which seems to work correctly:

Can you give me more details about how to reproduce the issue you're seeing?

At the moment there is no possibilty to watch a repo

(Bug at your edit form, I can't edit the projects, and add Diffusion, if I forget this at the creation of this task)

In T9908#148901, @chad wrote:

I can reproduce it on Windows 10 / Chrome, but not Mac / Chrome.

I can reproduce it on Windows 10 / Chrome, but not Mac / Chrome.

I can reproduce on Windows/Chrome: As long as the Actions field is in focus and not open, hitting "down arrow" adds an action.

My question was more what OS should I be testing.

In T9908#148885, @chad wrote:

Doesn't reproduce for me on Mac at least, should I be testing something more specific?

In T9908#148607, @epriestley wrote:

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

I can't reproduce this. Does it reproduce for you on this install?

Test

Doesn't reproduce for me on Mac at least, should I be testing something more specific?

This is a comment.

In T9908#148608, @chad wrote:

A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?

This doesn't reproduce for me, can you provide more details? It just goes down the select list (and I have to hit <enter> to make it trigger)

Broadly, if you're using arc land --hold <feature> to preview changes, there are three ways to proceed:

I'm not open to reverting to the old behavior. The new behavior solves a large number of problems for many users, discussed in T9657.

I am in the same boat as @hach-que right now. By destroying the original behavior, it really doesn't leave me any choices but to orphan everyone that I have trained to use arcanist on a very old version of the tool. I am 100% trusting of arcanist and its operations, but many people are afraid of tools like this. So they like options like --hold that allow them to inspect everything before they push it away. But now they would be instructed by the tool to run some funny command whose syntax they don't understand, and then also have to run

• git checkout master
• git pull

to get to where they wanted to be.