I am in the same boat as @hach-que right now. By destroying the original behavior, it really doesn't leave me any choices but to orphan everyone that I have trained to use arcanist on a very old version of the tool. I am 100% trusting of arcanist and its operations, but many people are afraid of tools like this. So they like options like --hold that allow them to inspect everything before they push it away. But now they would be instructed by the tool to run some funny command whose syntax they don't understand, and then also have to run

• git checkout master
• git pull

to get to where they wanted to be.

Since the change is not merge onto to the destination branch

Also, I noticed that the documentation for --hold is also out of date, in accordance with this bug report.

The change is merged into the target branch, following these rules:

Well realistically, there more steps between the arc land --hold and git push

Additionally, the hold now does not cleanup the feature branch either

I expect it to do what it used to do previously, which would be finish with a merge onto the desired landing branch. Rather now, if I use this, I have to do an additional

• git checkout master (remembering the commit I am leaving behind)
• git merge eb35b52

Then end with
git push

More information:

Awww. my google-foo has failed. Good deal.

Did an upgrade earlier this week, so probably pretty close... here are the commit hashes.

Aha! I found the culprit. Executing the command with bash debugging on, we get this:

dev@cosmo-box:~$ bash --debug arc
/home/dev/dev/arcanist/bin/arc: line 2: $'\r': command not found
/home/dev/dev/arcanist/bin/arc: line 5: $'\r': command not found
/home/dev/dev/arcanist/bin/arc: line 8: $'\r': command not found
/home/dev/dev/arcanist/bin/arc: arc: line 18: syntax error near unexpected token `done'
'home/dev/dev/arcanist/bin/arc: arc: line 18: `done;

After messing around a little bit, on all 3 of the other installations of arcanist that I have (that work fine), I am able to invoke arcanist/scripts/arcanist.php just by typing the name of the script. But only on my 14.04.1 box, that doesnt work. However, if I add 'php5' to the beginning of the command it works.

Here is a link to a folder that contains a virtualbox appliance of the system in question. It is currently uploading, expected to be done in probably 20-30 minutes, as it is 2.5gb.

Luckily, this is a virtualbox installation. So I can have an appliance packed up here soon.

More info about permissions

dev@dev-box:~$ ls -al arcanist/
total 16
drwxr-xr-x  4 dev dev 4096 Jan 31 12:44 .
drwxr-xr-x 21 dev dev 4096 Jan 31 13:03 ..
drwxr-xr-x  8 dev dev 4096 Jan 31 12:43 arcanist
drwxr-xr-x  8 dev dev 4096 Jan 31 12:44 libphutil

My directory structure is as follows: