Page MenuHomePhabricator

Repair the other half of Project and Revision subscriptions
Closed, WontfixPublic

Description

Just making a note of this so I don't forget: in both the recent projects migration and an upcoming revisions migration, I'm using efficient SQL queries to perform edge migrations. However, these don't write the other half of the edge and can't be made to safely in a world where we separate databases across hosts.

At some point in the not-too-distant future, we should run migrations to repair the other half of these edges. There's no product impact for the moment (no UI exists to show all objects you're subscribed to, for instance) and repair is straightforward.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added projects: Projects, Differential.
epriestley added subscribers: epriestley, btrahan.
epriestley claimed this task.

This hasn't caused any issues yet and we have no plans to show "stuff you're subscribed to".

I suspect I'm going to move reviewers back to a dedicated table so we can get rid of edge data.

If we ever need this stuff, we can write an edge repair tool fairly easily.