Page MenuHomePhabricator
Create Task
Maniphest T7642

Make ContentSource a property of $viewer
Closed, WontfixPublic
Actions

Description

We have a lot of setContentSourceFromRequest($request) but we could infer this from setActor($viewer) plus constructing/attaching content sources to viewers. In most major cases, we know the content source after authentication.

Related Objects

Event Timeline

epriestley created this task.Mar 22 2015, 1:19 PM
epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Infrastructure.
epriestley added a subscriber: epriestley.
epriestley mentioned this in T1112: Consider pathways for upgrading Differential inline comments to less-transient TODOs.Mar 27 2015, 12:56 PM
epriestley closed this task as Wontfix.Dec 14 2015, 7:26 PM
epriestley claimed this task.

The number of direct invocations of Editors in the codebase is decreasing over time, reducing the value of building this.

Phabricator · Built by Phacility