Page MenuHomePhabricator
Feed All Stories

Dec 12 2015

epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 12 2015, 2:51 AM · Phame
epriestley added a revision to T9360: Unbeta Phame: Unknown Object (Differential Revision).
Dec 12 2015, 2:49 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

The behavior of TITLE and VISIBILITY are also wrong: they emit the current body text, not the body text at the time the change was made.

Dec 12 2015, 2:49 AM · Phame
epriestley added a comment to T9360: Unbeta Phame.

I think this is happening because both the "Title" and "Body" transactions are emitting text:

Dec 12 2015, 2:44 AM · Phame
epriestley added a comment to T7345: Install PHPExcel in the cluster.

This should be ready to go with the deployment tomorrow:

Dec 12 2015, 2:39 AM · Phacility
starruler added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Ah that makes sense, when I load a page on my iPhone (iOS 9.1) it shows desktop site and flashes down to mobile. I guess the server thinks I'm a desktop. Note this happens even on an iPhone 4s simulator (the oldest version I can run).

Dec 12 2015, 2:36 AM · Safari, Differential, Bug Report
joshuaspence added a project to T9968: Phame can fatal if handed an older-style URI: Phame.
Dec 12 2015, 2:26 AM · Phame, Bug Report
chad updated the task description for T9897: Unbeta Feedback on Phame.
Dec 12 2015, 2:24 AM · Phame
chad added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

The 1-up renderer is server-side, it's not responsive CSS. Reload the page after you shrink.

Dec 12 2015, 2:20 AM · Safari, Differential, Bug Report
epriestley updated the post content for Blog Post: Development Notes (2015 Week 50).
Dec 12 2015, 2:08 AM
epriestley edited the content of Changelog.
Dec 12 2015, 2:08 AM
epriestley created 2015 Week 50 (Early December).
Dec 12 2015, 2:07 AM
starruler added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I was able to repro on Mac OS X with a recent version of chrome.

Dec 12 2015, 2:07 AM · Safari, Differential, Bug Report
chad added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I'm on iOS 9.2

Dec 12 2015, 2:03 AM · Safari, Differential, Bug Report
chad added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

image.png (1×750 px, 83 KB)

Dec 12 2015, 2:03 AM · Safari, Differential, Bug Report
chad renamed T9969: Differential 1-up render doesn't trigger on iOS from 'Show 20 lines' broken on mobile devices to 'Show 20 lines' broken on mobile Safari.
Dec 12 2015, 2:02 AM · Safari, Differential, Bug Report
chad added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

In Safari/iOS I intermittently get the desktop site. No issues in Chrome.

Dec 12 2015, 1:58 AM · Safari, Differential, Bug Report
epriestley renamed Blog Post: Development Notes (2015 Week 50) blog post from to Development Notes (2015 Week 50).
Dec 12 2015, 1:52 AM
starruler added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

That screenshot was taken as a 'logged out' user. There were two columns (so not unified diffs?)

Dec 12 2015, 1:52 AM · Safari, Differential, Bug Report
starruler added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

iPhone 5s simulator

Dec 12 2015, 1:51 AM · Safari, Differential, Bug Report
epriestley added a comment to T9927: Improve PhameHome.

New blogs element is great :3

Dec 12 2015, 1:51 AM · Phame
epriestley awarded T9927: Improve PhameHome a Mountain of Wealth token.
Dec 12 2015, 1:50 AM · Phame
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Oh, there are only two options and neither would break this.

Dec 12 2015, 1:45 AM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Is Settings → Diff Preferences → Show Unified Diffs set to "On Small Screens" (the default) for you?

Dec 12 2015, 1:44 AM · Safari, Differential, Bug Report
starruler created T9969: Differential 1-up render doesn't trigger on iOS.
Dec 12 2015, 1:40 AM · Safari, Differential, Bug Report
epriestley closed T9968: Phame can fatal if handed an older-style URI as Resolved.

D14747 should fix this. I haven't pushed that yet, but I updated all the changelogs.

Dec 12 2015, 1:36 AM · Phame, Bug Report
epriestley renamed T9968: Phame can fatal if handed an older-style URI from Phame Fatal to Phame can fatal if handed an older-style URI.
Dec 12 2015, 1:36 AM · Phame, Bug Report
epriestley edited the content of 2015 Week 49 (Very Early December).
Dec 12 2015, 1:32 AM
epriestley edited the content of 2015 Week 48 (Very Late November).
Dec 12 2015, 1:32 AM
epriestley edited the content of 2015 Week 47 (Late November).
Dec 12 2015, 1:32 AM
epriestley edited the content of 2015 Week 45 (Early November).
Dec 12 2015, 1:31 AM
epriestley edited the content of 2015 Week 44 (Very Late October).
Dec 12 2015, 1:31 AM
epriestley edited the content of 2015 Week 43 (Late October).
Dec 12 2015, 1:31 AM
epriestley edited the content of 2015 Week 42 (Mid October).
Dec 12 2015, 1:30 AM
epriestley edited the content of 2015 Week 41 (Early October).
Dec 12 2015, 1:30 AM
epriestley added a revision to T9968: Phame can fatal if handed an older-style URI: Unknown Object (Differential Revision).
Dec 12 2015, 1:28 AM · Phame, Bug Report
epriestley added a comment to T9968: Phame can fatal if handed an older-style URI.

The URI scheme changed but this shouldn't fatal. I'll fix the fatal and then go fix the links in the changelogs, there are only like 6 of them or something.

Dec 12 2015, 1:23 AM · Phame, Bug Report
epriestley claimed T9968: Phame can fatal if handed an older-style URI.
Dec 12 2015, 1:22 AM · Phame, Bug Report
chad updated subscribers of T9968: Phame can fatal if handed an older-style URI.
Dec 12 2015, 1:17 AM · Phame, Bug Report
starruler added a comment to T9968: Phame can fatal if handed an older-style URI.

Looks like the URL scheme migh thave just changed? I was able to get to the post by navigating to phame home: https://secure.phabricator.com/w/changelog/2015.49/

Dec 12 2015, 1:11 AM · Phame, Bug Report
starruler created T9968: Phame can fatal if handed an older-style URI.
Dec 12 2015, 1:10 AM · Phame, Bug Report
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 12 2015, 1:03 AM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

I can't reproduce this. Does it reproduce for you on this install?

Dec 12 2015, 1:02 AM · ApplicationEditor
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
In T9908#148608, @chad wrote:

A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?

This doesn't reproduce for me, can you provide more details? It just goes down the select list (and I have to hit <enter> to make it trigger)

Dec 12 2015, 1:00 AM · ApplicationEditor
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

I think this should now be fixed in HEAD. Let us know if we missed anything, and thanks for the report.

Dec 12 2015, 1:00 AM · Security, Bug Report
chad added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

A minor usability issue as well... If you click on the "Add Action" drop down and continually press the down key then you end up adding every action. Maybe we can just disable this behavior?

Dec 12 2015, 12:55 AM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

It doesn't seem to work properly if I try to comment and also change the status of a task. The comment appears but the task status remains unchanged.

Dec 12 2015, 12:54 AM · ApplicationEditor
epriestley closed T9966: Diffusion credentials may be leaked under some circumstances as Resolved by committing Restricted Diffusion Commit.
Dec 12 2015, 12:53 AM · Security, Bug Report
epriestley added a revision to T9966: Diffusion credentials may be leaked under some circumstances: Unknown Object (Differential Revision).
Dec 12 2015, 12:52 AM · Security, Bug Report
joshuaspence added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

I noticed a few minor issues after deploying this on our install.

Dec 12 2015, 12:44 AM · ApplicationEditor
chad added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

Without steps to reproduce the issue, what specifically do you suggest we do with this ticket?

Dec 12 2015, 12:43 AM · Security, Bug Report
kaya added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

So you haven't actually reproduced this yourself? Is it possible that the user mistook xxxxx as uncensored credentials? Can you try reproducing it directly?

I can't reproduce this locally even with a username email.

Dec 12 2015, 12:31 AM · Security, Bug Report
chad renamed T9336: Link profile image in feed from Link profile image in timeline and feed to Link profile image in feed.
Dec 12 2015, 12:29 AM · Badge Awarded, PHUI
nipunn added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

That prioritization makes sense to me. It doesn't seem worth putting a lot of effort into optimizing the workflow for a bad configuration.

Dec 12 2015, 12:17 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

So you haven't actually reproduced this yourself? Is it possible that the user mistook xxxxx as uncensored credentials? Can you try reproducing it directly?

Dec 12 2015, 12:12 AM · Security, Bug Report
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

I should note that we're running the latest version of Git (2.6.3) which could be the culprit. From my superficial inspection of the code, it appears that the output of git fetch is simply reflected.

Dec 12 2015, 12:11 AM · Security, Bug Report
kaya added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

In your report, you say <user email address> -- is the login username for this user a string including "@"? Does the UI print out a message like this?

https://xxxxx@domain.com:password@remote.example.com/...

..that is, the beginning of the email address is censored, but the rest of it is not and the password and domain are not? Or is the HTTP username not really an email address?

Dec 12 2015, 12:11 AM · Security, Bug Report
kaya added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

I should note that we're running the latest version of Git (2.6.3) which could be the culprit. From my superficial inspection of the code, it appears that the output of git fetch is simply reflected.

Dec 12 2015, 12:08 AM · Security, Bug Report
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

In your report, you say <user email address> -- is the login username for this user a string including "@"? Does the UI print out a message like this?

Dec 12 2015, 12:06 AM · Security, Bug Report
epriestley added a comment to T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Until we have such a tool, you can revoke keys like this:

Dec 12 2015, 12:01 AM · Auth, Feature Request

Dec 11 2015

kaya added a comment to T9966: Diffusion credentials may be leaked under some circumstances.
phabricator 7ce84cc27b81a390d4a0d0c224dbc18597d6c1cc (Fri, Dec 4) 
arcanist 05ac4a67e22e06e836e2a0abfba1aa9826490e44 (Fri, Dec 4) 
phutil a6802e4d6b5f6ac4ada2256de27effa2b7189d0a (Fri, Dec 4)
Dec 11 2015, 11:57 PM · Security, Bug Report
epriestley triaged T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff as Wishlist priority.

I think this is worth improving. However, I think it is not a very important feature in situations where things are set up reasonably well (not too many lint false positives, fairly fast tests or server-side CI), and that fixing these problems will have a lot of other benefits in cases where they aren't working well. That is, this should be more like a "nice-to-have" that saves you a few seconds once a week, not something you're hitting on >50% of revisions.

Dec 11 2015, 11:53 PM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
avivey added a comment to T9336: Link profile image in feed.

I may have wanted to say "set loose"... :)

Dec 11 2015, 11:42 PM · Badge Awarded, PHUI
epriestley added a comment to T9336: Link profile image in feed.

Can I set looks an intern on this?

Dec 11 2015, 11:41 PM · Badge Awarded, PHUI
avivey reopened T9336: Link profile image in feed as "Open".
Dec 11 2015, 11:40 PM · Badge Awarded, PHUI
avivey added a comment to T9336: Link profile image in feed.

Right - I've miss-read the title.

Dec 11 2015, 11:36 PM · Badge Awarded, PHUI
epriestley added a comment to T9336: Link profile image in feed.

Although timeline is now linked, I think feed still isn't linked?

Dec 11 2015, 11:35 PM · Badge Awarded, PHUI
nipunn added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

I was able to get some metrics for how many revisions have lint errors in this particular project (repo callsign 'C') with this query:

Dec 11 2015, 11:34 PM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley added a comment to T9966: Diffusion credentials may be leaked under some circumstances.

What version of Phabricator are you running? (You can find this in Config → Versions for recent versions.)

Dec 11 2015, 11:33 PM · Security, Bug Report
avivey closed T9336: Link profile image in feed as Resolved.
Dec 11 2015, 11:33 PM · Badge Awarded, PHUI
epriestley added a comment to T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.

Do you have the public key (or the private key), or do you just know which user has a compromised key but not know which key is compromised?

Dec 11 2015, 11:29 PM · Auth, Feature Request
epriestley added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

I can't reproduce that. Here's a search using "Path", which seems to work correctly:

Dec 11 2015, 11:25 PM · Maniphest, Phame, Owners, Arcanist, Conduit
nickz created T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects.
Dec 11 2015, 10:50 PM · Auth, Feature Request
kaya created T9966: Diffusion credentials may be leaked under some circumstances.
Dec 11 2015, 10:16 PM · Security, Bug Report
nickz added a comment to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.

You might already know, but I noticed that the owners search is broken if I use "path" instead of "Repositories" to query. Also it would be great if we can use the package name to search.

Dec 11 2015, 9:56 PM · Maniphest, Phame, Owners, Arcanist, Conduit
jcarrillo7 added a comment to T3462: In Differential, expose "featurename (branched from master)" via Conduit.

@epriestley can this information (branched from master) be exposed via conduit as well? Seems like a simple addition to differential.query

Dec 11 2015, 9:28 PM · Differential, Arcanist
chad added a revision to T9927: Improve PhameHome: Unknown Object (Differential Revision).
Dec 11 2015, 9:21 PM · Phame
chad closed Q245: How can I use phabricator in this case? as resolved.
Dec 11 2015, 9:21 PM
angie moved T8405: Making lint easier to use from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 11 2015, 8:27 PM · Lint, Restricted Project
angie moved T7617: Make it easier to know why herald adds reviewers from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 11 2015, 8:26 PM · Restricted Project, Herald
epriestley closed T9965: Don't require newline for Differential Revision autoclose magic as Invalid.

This request does not describe a root problem.

Dec 11 2015, 8:24 PM · Feature Request
angie moved T9605: Running prod daemons fails on test files from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 11 2015, 8:22 PM · Daemons, Restricted Project
angie moved T9367: Add another accept state for code review from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Dec 11 2015, 8:22 PM · Differential, Restricted Project
nochum created T9965: Don't require newline for Differential Revision autoclose magic.
Dec 11 2015, 8:03 PM · Feature Request
epriestley added projects to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Conduit, Arcanist, Owners, Phame, Maniphest.
Dec 11 2015, 7:49 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Dec 11 2015, 7:39 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T9964: Fill in Conduit support infrastructure for ApplicationEditor changes: Unknown Object (Differential Revision).
Dec 11 2015, 7:39 PM · Maniphest, Phame, Owners, Arcanist, Conduit
epriestley created T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
Dec 11 2015, 7:35 PM · Maniphest, Phame, Owners, Arcanist, Conduit
chad closed T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist" as Resolved.

Awesome, good to hear.

Dec 11 2015, 7:22 PM · Bug Report
AleisterWeber added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

Yep, that did the trick for me. Sometimes your are just to blind to see. Thank you guys for your help. Phabricator works now perfectly.

Dec 11 2015, 7:21 PM · Bug Report
chad triaged T9927: Improve PhameHome as High priority.
Dec 11 2015, 7:01 PM · Phame
chad added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

I'd focus on getting the user access to create databases, you'll want it in the future as well to streamline updates.

Dec 11 2015, 6:59 PM · Bug Report
AleisterWeber added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

Tried this Installation Guide, and it worked until the point where you have to do the Database upgrade. But it seems like the database user from Plesk (create for phabricator with full permission, thats what plesk told) has no permission to create new Databases.

Dec 11 2015, 6:57 PM · Bug Report
chad added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

Also our documentation is way more hilarious.

Dec 11 2015, 6:56 PM · Bug Report
chad added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

(there should be no reason to create databases by hand)

Dec 11 2015, 6:54 PM · Bug Report
chad added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

We only support installation from our guide, other guides may be out of date or inaccurate in general.

Dec 11 2015, 6:54 PM · Bug Report
AleisterWeber added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

@avivey followed an instruction from a plesk forum.
@chad not 100% sure if it counts as a shared host. I'm installing on a VPS with Root.

Dec 11 2015, 6:53 PM · Bug Report
chad added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

Are you installing Phabricator on a shared host?

Dec 11 2015, 6:51 PM · Bug Report
avivey added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

Added the Databases from ./bin/storage databases by hand in Plesk

Dec 11 2015, 6:50 PM · Bug Report
chad added a comment to T9962: Installation failed "Table phabricator_dashboard.dashboard doesn't exist".

Added the Databases from ./bin/storage databases by hand in Plesk

Dec 11 2015, 6:49 PM · Bug Report