Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

May 4 2020

epriestley added a revision to T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes: D21210: Fix an issue where text intradiff bodies may not render.
May 4 2020, 2:39 PM · Differential

May 1 2020

epriestley added a revision to T13520: Update the diff table of contents for moved files, long paths, etc: D21205: Use underlines instead of background color to show file moves/renames.
May 1 2020, 7:22 PM · Differential
dwilches added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Thanks! I didn't know it could be done from the web UI.

May 1 2020, 3:32 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Apr 30 2020

epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

You can open the revision in the web UI and "Request Review". You can use arc diff --browse ... to open the web UI automatically.

Apr 30 2020, 9:00 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
dwilches added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

We just found a real issue with this, different from what I mentioned above: We had an issue with our CI machine, and to fix it we needed to make a diff. But as the CI machine is not working, the diff won't build, which means we can't accept the diff that will solve the issue.

Apr 30 2020, 7:25 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
dwilches added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Is there a way to disable this option via a config in the server or a CLI parameter?

Apr 30 2020, 5:21 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21191: When users submit "editing" inlines, warn them that their inlines will be saved.
Apr 30 2020, 12:15 AM · Inline Comments, Diffusion, Differential

Apr 29 2020

epriestley added a revision to T13519: Support collapsing folders in the diff paths panel: D21189: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()".
Apr 29 2020, 9:45 PM · Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

As of D21188, inlines have these remaining weird behaviors:

Apr 29 2020, 7:16 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21188: When draft inline comments are submitted, disengage the editor.
Apr 29 2020, 7:00 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21187: When a user clicks "Cancel" on an inline comment to leave the "Editing" state, save the state change.
Apr 29 2020, 6:34 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21186: Make "editing" state persistent for inline comments.
Apr 29 2020, 2:56 PM · Inline Comments, Diffusion, Differential
epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

In the DOM, inline comments are currently structured as a "comment row", followed by zero or more related rows (which may contain the editor UI or the undo UI).

Apr 29 2020, 2:12 PM · Inline Comments, Diffusion, Differential

Apr 28 2020

epriestley added a comment to T13513: Make schema changes to inlines to prepare for new inline features.

OKAY SO

Apr 28 2020, 9:29 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13513: Make schema changes to inlines to prepare for new inline features: D21184: Add generic "attributes" storage to inline comment tables.
Apr 28 2020, 8:48 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13520: Update the diff table of contents for moved files, long paths, etc: D21183: Update the diff table of contents to use hierarchical views and edit distance renames.
Apr 28 2020, 7:23 PM · Differential
epriestley added a revision to T13520: Update the diff table of contents for moved files, long paths, etc: D21182: Replace "PhutilFileTree" with a more abstract "VectorTree".
Apr 28 2020, 7:06 PM · Differential
epriestley moved T12982: In Differential, diff-of-diffs where both diffs added an identical file is misleading from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:27 PM · Differential
epriestley moved T10500: When diffing B against A in Differential, files touched in A but not B should be finessed better from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:26 PM · Restricted Project, Differential
epriestley moved T9792: Download raw diff from Differential weirdness regarding diff including binary files additions/deletions from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:26 PM · Differential
epriestley moved T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes from Backlog to Intradiffs on the Differential board.
Apr 28 2020, 1:23 PM · Differential
epriestley renamed T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes from Update logic around interdiff changesets to better handle binary files, header information, and attributes to Update logic around intradiff changesets to better handle binary files, header information, and attributes.
Apr 28 2020, 1:22 PM · Differential
epriestley moved T1101: Allow Show Raw File for updated added files from v2 (UI/Mobile) to Intradiffs on the Differential board.
Apr 28 2020, 1:22 PM · Differential
epriestley added a revision to T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes: D21180: Improve the construction of synthetic "comparison/intradiff" changesets.
Apr 28 2020, 12:00 PM · Differential

Apr 27 2020

epriestley added a comment to T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes.

These issues are somewhat complicated because changesets currently have a single changeType attribute and a single fileType attribute, and a lot of rendering logic depends on these attributes. This model isn't correct in the general case.

Apr 27 2020, 10:42 PM · Differential
epriestley closed T13524: "Undefined index" exception in ChangesetParser while viewing diffs as Resolved.

This seems to be fixed and has deployed to the cluster.

Apr 27 2020, 9:56 PM · Differential
epriestley added a revision to T13524: "Undefined index" exception in ChangesetParser while viewing diffs: D21178: Fix an invalid index access for synthetic lint inline comments from Harbormaster.
Apr 27 2020, 9:18 PM · Differential
epriestley added a comment to T13524: "Undefined index" exception in ChangesetParser while viewing diffs.

This appears to be an issue with synthetic lint messages from Harbormaster that do not specify a line number. We reach this section of the code:

Apr 27 2020, 9:09 PM · Differential
epriestley triaged T13524: "Undefined index" exception in ChangesetParser while viewing diffs as Normal priority.
Apr 27 2020, 8:51 PM · Differential
epriestley triaged T13523: Update logic around intradiff changesets to better handle binary files, header information, and attributes as Normal priority.
Apr 27 2020, 3:45 PM · Differential
epriestley added a revision to T13522: Compute an internal content hash of large files using hash-of-hashes: D21174: For changesets that affect binaries, use the new binary file content hash as an effect hash.
Apr 27 2020, 3:29 PM · Differential, Files
epriestley triaged T13522: Compute an internal content hash of large files using hash-of-hashes as Wishlist priority.
Apr 27 2020, 2:48 PM · Differential, Files
epriestley updated the task description for T13455: Make "View Options" in Differential sticky across reloads.
Apr 27 2020, 2:32 PM · Differential
epriestley closed T13455: Make "View Options" in Differential sticky across reloads as Resolved.
  • Followups on "Hidden" logic have moved to T13519.
Apr 27 2020, 2:32 PM · Differential
epriestley closed T13455: Make "View Options" in Differential sticky across reloads, a subtask of T13515: Differential: Inlines and View Options, as Resolved.
Apr 27 2020, 2:32 PM · Differential
epriestley closed T13516: Remove the "filetree" setting (so it's always enabled for everyone), a subtask of T13515: Differential: Inlines and View Options, as Resolved.
Apr 27 2020, 2:31 PM · Differential
epriestley closed T13516: Remove the "filetree" setting (so it's always enabled for everyone) as Resolved.
  • Collapsing paths has moved forward to T13519.
  • Table of Contents updates have moved forward to T13520.
  • FormationView issues have moved forward to T13521.
Apr 27 2020, 2:31 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 27 2020, 2:30 PM · Diffusion, Differential
epriestley triaged T13521: FormationView could do more Javascript magic around device layouts and header elements as Low priority.
Apr 27 2020, 2:30 PM · Differential
epriestley triaged T13520: Update the diff table of contents for moved files, long paths, etc as Normal priority.
Apr 27 2020, 2:24 PM · Differential
epriestley triaged T13519: Support collapsing folders in the diff paths panel as Low priority.
Apr 27 2020, 2:15 PM · Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 27 2020, 2:10 PM · Diffusion, Differential

Apr 24 2020

epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21166: Stick the page footer in the right place on Formation View pages.
Apr 24 2020, 6:21 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 24 2020, 12:20 PM · Diffusion, Differential

Apr 23 2020

epriestley updated the task description for T13455: Make "View Options" in Differential sticky across reloads.
Apr 23 2020, 9:52 PM · Differential
epriestley added a revision to T13455: Make "View Options" in Differential sticky across reloads: D21164: Add a very forgiving GC for Differential viewstate information.
Apr 23 2020, 9:01 PM · Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 23 2020, 8:34 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21163: Update static resource package definitions.
Apr 23 2020, 8:34 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21162: Don't show the "file tree" view on tablets/phones.
Apr 23 2020, 8:17 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 23 2020, 8:05 PM · Diffusion, Differential
epriestley updated the task description for T13455: Make "View Options" in Differential sticky across reloads.
Apr 23 2020, 5:16 PM · Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21161: Refine more Differential review state behaviors.
Apr 23 2020, 5:10 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 23 2020, 5:09 PM · Diffusion, Differential
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 23 2020, 5:08 PM · Plans, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 23 2020, 5:07 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21160: Update the "View Options" menu for recent filetree changes.
Apr 23 2020, 3:11 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 23 2020, 1:48 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 23 2020, 1:47 PM · Diffusion, Differential

Apr 22 2020

epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 22 2020, 8:51 PM · Diffusion, Differential
epriestley closed T7467: Consider giving deleted files a more prominent treatment in the changeset UI as Resolved.

This is quite old and I'm not sure it's particularly relevant anymore. T13516 has made some related changes.

Apr 22 2020, 8:51 PM · Restricted Project, Differential
epriestley updated the task description for T13515: Differential: Inlines and View Options.
Apr 22 2020, 8:50 PM · Differential
epriestley updated the task description for T13513: Make schema changes to inlines to prepare for new inline features.
Apr 22 2020, 8:49 PM · Inline Comments, Diffusion, Differential
epriestley added a revision to T13455: Make "View Options" in Differential sticky across reloads: D21158: Make "hidden" changesets sticky, and show hidden state in the filetree.
Apr 22 2020, 8:24 PM · Differential
epriestley updated the task description for T13455: Make "View Options" in Differential sticky across reloads.
Apr 22 2020, 8:24 PM · Differential
epriestley added a comment to T13455: Make "View Options" in Differential sticky across reloads.

Currently, I also think no part of this pipeline can actually tell if changeset X changed at diff Y or not, but this isn't conceptually hard to get right most of the time.

Apr 22 2020, 7:14 PM · Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21157: Mark "low importance" and "owned" changes in the filetree.
Apr 22 2020, 6:00 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 22 2020, 3:53 PM · Diffusion, Differential
epriestley added a comment to T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.

Filetree stuff is now in T13516: Remove the "filetree" setting (so it's always enabled for everyone).

Apr 22 2020, 3:21 PM · Plans, Differential
epriestley updated the task description for T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions.
Apr 22 2020, 3:20 PM · Plans, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21156: Show change information in file icons in the filetree.
Apr 22 2020, 3:20 PM · Diffusion, Differential

Apr 21 2020

epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21155: When a directory has a single directory child, collapse them into a single "a/b/" path entry.
Apr 21 2020, 10:56 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21154: Entirely replace the old filetree UI with the "flank" UI.
Apr 21 2020, 10:21 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 21 2020, 9:51 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21153: Roughly style the new "flank" paths UI.
Apr 21 2020, 9:04 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 21 2020, 9:03 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 21 2020, 8:36 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21152: Generate file trees from changesets in the new flank UI.
Apr 21 2020, 6:54 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 21 2020, 6:27 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21151: Glue the new FormationView on top of the older Filetree view in Differential.
Apr 21 2020, 4:45 PM · Diffusion, Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21150: Add a "FormationView" to support dynamic flank panels.
Apr 21 2020, 2:23 PM · Diffusion, Differential

Apr 20 2020

epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 20 2020, 10:13 PM · Diffusion, Differential
epriestley added a comment to T13516: Remove the "filetree" setting (so it's always enabled for everyone).

Pretty much ready to ship:

Apr 20 2020, 3:41 PM · Diffusion, Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 20 2020, 2:24 PM · Diffusion, Differential

Apr 19 2020

epriestley updated the task description for T13515: Differential: Inlines and View Options.
Apr 19 2020, 5:01 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21149: Restore editor behavior to Diffusion and support "\" shortcut.
Apr 19 2020, 3:57 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21148: In Differential, make the "Open in Editor" keystroke work with no selection, or a change or inline selected.
Apr 19 2020, 2:20 PM · Differential
epriestley updated the task description for T13516: Remove the "filetree" setting (so it's always enabled for everyone).
Apr 19 2020, 2:17 PM · Diffusion, Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21147: Add "short name", "id", and "phid" variables for external editor URIs.
Apr 19 2020, 2:09 PM · Differential

Apr 18 2020

epriestley added a revision to T13515: Differential: Inlines and View Options: D21146: Add static errors, supported protocols, and a dynamic function listing to external editor settings page.
Apr 18 2020, 11:12 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21145: Remove the very janky URI-based "Saved Changes" code.
Apr 18 2020, 10:26 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21144: Replace old hard-coded URI-based "changes saved" jank with new overgeneralized cookie-based "changes saved" jank.
Apr 18 2020, 10:24 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21143: Tokenize external editor links so they can be safely materialized on the client.
Apr 18 2020, 9:31 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21142: Remove the "Edit Multiple Files" external editor setting.
Apr 18 2020, 6:34 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21141: Make the "Keyboard Shortcuts" dialog in Differential less hideous.
Apr 18 2020, 6:25 PM · Differential
epriestley added a revision to T13515: Differential: Inlines and View Options: D21140: Move "External Editor" settings to a separate settings group.
Apr 18 2020, 4:56 PM · Differential
epriestley added a revision to T13516: Remove the "filetree" setting (so it's always enabled for everyone): D21139: Remove the "Filetree" preference, so it's on for everyone.
Apr 18 2020, 4:48 PM · Diffusion, Differential
epriestley renamed T13516: Remove the "filetree" setting (so it's always enabled for everyone) from Remove the "filetree" setting to Remove the "filetree" setting (so it's always enabled for everyone).
Apr 18 2020, 4:48 PM · Diffusion, Differential
epriestley added a comment to T13455: Make "View Options" in Differential sticky across reloads.

To save this setting, the shortest path is to just reload the change with an option like justSaveViewStateDoNotActuallyRenderAnything=true. But, since reloading changes is per-changeset, this is inefficient if filetree changes out of T13516 support collapsing multiple files at once.

Apr 18 2020, 3:09 PM · Differential
epriestley triaged T13516: Remove the "filetree" setting (so it's always enabled for everyone) as Low priority.
Apr 18 2020, 2:51 PM · Diffusion, Differential

Apr 17 2020

epriestley added a revision to T13455: Make "View Options" in Differential sticky across reloads: D21138: Make "renderer", "engine", and "encoding" sticky across reloads in Differential and Diffusion.
Apr 17 2020, 11:18 PM · Differential
First
Prev
Next
Phabricator · Built by Phacility