Page MenuHomePhabricator

For changesets that affect binaries, use the new binary file content hash as an effect hash
ClosedPublic

Authored by epriestley on Apr 27 2020, 3:29 PM.
Tags
None
Referenced Files
F19083302: D21174.id.diff
Tue, Dec 2, 12:33 PM
F19014941: D21174.diff
Sat, Nov 22, 10:05 PM
F18985459: D21174.diff
Mon, Nov 17, 1:03 PM
F18984351: D21174.diff
Mon, Nov 17, 11:35 AM
F18762942: D21174.diff
Oct 6 2025, 9:41 PM
F18761431: D21174.id50421.diff
Oct 6 2025, 2:19 PM
F18761278: D21174.id.diff
Oct 6 2025, 1:22 PM
F18761273: D21174.id50422.diff
Oct 6 2025, 1:20 PM
Subscribers
None

Details

Summary

Ref T13522. When changesets update an image, we currently compute no effect hash. A content hash of the image (or other binary file) is a reasonable effect hash, and enalbes effect-hash-based behavior, including hiding files in intradiffs.

Test Plan
  • Created a revision affecting cat.png and quack.txt (currently, there must be 2+ changesets to trigger the hide logic).
  • Updated it with the exact same changes.
  • Viewed revision:
    • Saw the image renderered in the interdiff.
  • Applied patch.
  • Ran bin/differential rebuild-changesets ....
  • Viewed revision:
    • Saw both changesets collapse as unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable