Page MenuHomePhabricator

For changesets that affect binaries, use the new binary file content hash as an effect hash
ClosedPublic

Authored by epriestley on Apr 27 2020, 3:29 PM.
Tags
None
Referenced Files
F15580523: D21174.id50422.diff
Wed, May 7, 6:11 AM
F15571220: D21174.diff
Mon, May 5, 4:50 AM
F15566798: D21174.id50421.diff
Thu, May 1, 11:51 PM
F15560694: D21174.id.diff
Tue, Apr 29, 4:06 PM
F15557349: D21174.diff
Mon, Apr 28, 9:10 PM
F15481727: D21174.diff
Tue, Apr 8, 10:32 PM
F15458662: D21174.id50422.diff
Mar 31 2025, 6:07 AM
F15454310: D21174.id.diff
Mar 29 2025, 5:51 PM
Subscribers
None

Details

Summary

Ref T13522. When changesets update an image, we currently compute no effect hash. A content hash of the image (or other binary file) is a reasonable effect hash, and enalbes effect-hash-based behavior, including hiding files in intradiffs.

Test Plan
  • Created a revision affecting cat.png and quack.txt (currently, there must be 2+ changesets to trigger the hide logic).
  • Updated it with the exact same changes.
  • Viewed revision:
    • Saw the image renderered in the interdiff.
  • Applied patch.
  • Ran bin/differential rebuild-changesets ....
  • Viewed revision:
    • Saw both changesets collapse as unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable