Page MenuHomePhabricator

For changesets that affect binaries, use the new binary file content hash as an effect hash
ClosedPublic

Authored by epriestley on Apr 27 2020, 3:29 PM.
Tags
None
Referenced Files
F19816306: D21174.id50421.diff
Mar 5 2026, 4:55 AM
F19814528: D21174.id50422.diff
Mar 4 2026, 2:17 PM
F19811094: D21174.id50422.diff
Mar 3 2026, 10:33 PM
F19809171: D21174.diff
Mar 3 2026, 8:23 AM
F19803687: D21174.id50422.diff
Mar 2 2026, 1:16 AM
F19803483: D21174.id50421.diff
Mar 1 2026, 11:47 PM
F19802417: D21174.id50422.diff
Mar 1 2026, 4:36 PM
F19799044: D21174.diff
Feb 27 2026, 10:49 PM
Subscribers
None

Details

Summary

Ref T13522. When changesets update an image, we currently compute no effect hash. A content hash of the image (or other binary file) is a reasonable effect hash, and enalbes effect-hash-based behavior, including hiding files in intradiffs.

Test Plan
  • Created a revision affecting cat.png and quack.txt (currently, there must be 2+ changesets to trigger the hide logic).
  • Updated it with the exact same changes.
  • Viewed revision:
    • Saw the image renderered in the interdiff.
  • Applied patch.
  • Ran bin/differential rebuild-changesets ....
  • Viewed revision:
    • Saw both changesets collapse as unchanged.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable