Page MenuHomePhabricator

Add static errors, supported protocols, and a dynamic function listing to external editor settings page
ClosedPublic

Authored by epriestley on Apr 18 2020, 11:11 PM.
Tags
None
Referenced Files
F18790998: D21146.id50355.diff
Wed, Oct 15, 10:37 PM
F18734248: D21146.id.diff
Tue, Sep 30, 10:50 PM
F18656602: D21146.id.diff
Mon, Sep 22, 10:58 PM
F18454380: D21146.id50355.diff
Sep 1 2025, 5:02 AM
F18379020: D21146.diff
Aug 28 2025, 3:12 PM
F18101019: D21146.diff
Aug 9 2025, 12:16 PM
F18081619: D21146.id50355.diff
Aug 5 2025, 1:12 AM
F18081616: D21146.id.diff
Aug 5 2025, 1:10 AM
Subscribers
None

Details

Summary

Ref T13515.

  • Previously valid editor URIs may become invalid without being changed (if an administrator removes a protocol from the list, for example), but this isn't explained very well. Show an error on the settings page if the current value isn't usable.
  • Generate a list of functions from an authority in the parser.
  • Generate a list of protocols from configuration.
Test Plan

Screen Shot 2020-04-18 at 4.11.15 PM.png (1×1 px, 431 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.