Page MenuHomePhabricator

Add static errors, supported protocols, and a dynamic function listing to external editor settings page
ClosedPublic

Authored by epriestley on Apr 18 2020, 11:11 PM.
Tags
None
Referenced Files
F19083279: D21146.id50355.diff
Tue, Dec 2, 12:33 PM
F18985440: D21146.id50343.diff
Nov 17 2025, 1:02 PM
F18982823: D21146.id.diff
Nov 17 2025, 7:24 AM
F18943295: D21146.id50343.diff
Nov 11 2025, 1:43 PM
F18813203: D21146.id50343.diff
Oct 20 2025, 2:35 PM
F18807992: D21146.id50355.diff
Oct 19 2025, 4:27 AM
F18804555: D21146.diff
Oct 18 2025, 9:36 AM
F18790998: D21146.id50355.diff
Oct 15 2025, 10:37 PM
Subscribers
None

Details

Summary

Ref T13515.

  • Previously valid editor URIs may become invalid without being changed (if an administrator removes a protocol from the list, for example), but this isn't explained very well. Show an error on the settings page if the current value isn't usable.
  • Generate a list of functions from an authority in the parser.
  • Generate a list of protocols from configuration.
Test Plan

Screen Shot 2020-04-18 at 4.11.15 PM.png (1×1 px, 431 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:37 PM
This revision was automatically updated to reflect the committed changes.