Page MenuHomePhabricator

Support collapsing folders in the diff paths panel
Open, LowPublic

Description

Previously, see T13516. See PHI356.

The new paths panel should support toggling folders open or closed, but when you close a folder in the paths panel that should also hide the contained changesets in the main view.

It's complicated to keep the paths panel and main view in sync because users may hide and show files from the main view, hide and show entire paths from the panel, and files may be "forced" to be shown by updates to the diff. This likely requires tracking several different pieces of state information corresponding to explicit and implicit hide/show state, not a single "show / hide" flag.

  • T13455 introduced logic to re-show updated changesets after diff updates. This may not actually work well, and should be tested more thoroughly and hinted to users ("You previously hid this file, but it has been updated.")
  • Collapsed folders should probably also fold up the comment counts for their contained changesets, and the "owned path" mark.