Page MenuHomePhabricator
Differential D21184

Add generic "attributes" storage to inline comment tables
ClosedPublic
Actions

Authored by epriestley on Apr 28 2020, 8:48 PM.
Tags
None
Referenced Files
F19012347: D21184.diff
Nov 22 2025, 12:32 PM
F18848074: D21184.id50520.diff
Oct 30 2025, 3:16 AM
F18813666: D21184.diff
Oct 20 2025, 6:19 PM
F18677392: D21184.id50447.diff
Sep 25 2025, 9:03 PM
F18392709: D21184.diff
Aug 29 2025, 8:30 AM
F18112302: D21184.diff
Aug 12 2025, 4:20 PM
F18104440: D21184.id50520.diff
Aug 10 2025, 12:23 PM
F18104314: D21184.id.diff
Aug 10 2025, 11:21 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP5ff0ae7d48a7: Add generic "attributes" storage to inline comment tables
Summary

Ref T13513. This plans for "currently editing", character range comments, code suggestions, document engine tracking. And absolutely nothing else.

Test Plan
  • Ran bin/storage upgrade -f, got a clean upgrade.
  • Created and submitted some inline comments; nothing exploded.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 28 2020, 8:48 PM
Owners added a subscriber: Restricted Owners Package.Apr 28 2020, 8:48 PM
Harbormaster completed remote builds in B24266: Diff 50447.Apr 28 2020, 8:49 PM
epriestley requested review of this revision.Apr 28 2020, 8:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:10 PM
Closed by commit rP5ff0ae7d48a7: Add generic "attributes" storage to inline comment tables (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5ff0ae7d48a7: Add generic "attributes" storage to inline comment tables.

Revision Contents
Changeset List

Diff 50520

View Options

resources/sql/autopatches/20200428.inline.01.differential.column.sql

Loading...
View Options

resources/sql/autopatches/20200428.inline.02.diffusion.column.sql

Loading...
View Options

resources/sql/autopatches/20200428.inline.03.differential.value.sql

Loading...
View Options

resources/sql/autopatches/20200428.inline.04.diffusion.value.sql

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransactionComment.php

Loading...
Phabricator · Built by Phacility