Page MenuHomePhabricator

Fix an issue where text intradiff bodies may not render
ClosedPublic

Authored by epriestley on Mon, May 4, 2:39 PM.

Details

Summary

Ref T13523. In the caching layer, there's a tricky clause about filetypes that skips some body rendering behavior.

Provide file type information which at least has a better chance of representing all changes (e.g., an image file may be replaced with a text file, but this can not be represented by a single file type).

Formalize "hasSourceTextBody()", to mean the changeset parser should engage the change as source text.

Test Plan

Intradiffed text changes, saw the body render properly.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Mon, May 4, 2:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 2:40 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.