Page MenuHomePhabricator

Fix an invalid index access for synthetic lint inline comments from Harbormaster
ClosedPublic

Authored by epriestley on Apr 27 2020, 9:18 PM.
Tags
None
Referenced Files
F15547648: D21178.diff
Sat, Apr 26, 7:56 PM
F15487984: D21178.id50432.diff
Thu, Apr 10, 6:36 PM
F15479567: D21178.id.diff
Apr 8 2025, 8:15 AM
F15478008: D21178.diff
Apr 7 2025, 7:36 PM
F15400473: D21178.id50433.diff
Mar 17 2025, 11:50 AM
F15330735: D21178.id50433.diff
Mar 7 2025, 7:58 AM
F15316009: D21178.diff
Mar 6 2025, 6:18 PM
Unknown Object (File)
Mar 2 2025, 9:36 PM
Subscribers
None

Details

Summary

Ref T13524. If a Harbormaster lint message has no line number (which is permitted), we try to access an invalid index here. This is an exception after D21044.

Treat comments with no line number as unchanged. These comments do not have "ghost" behavior and do not port across diffs.

Test Plan
  • Used "harbormaster.sendmessage" to submit lint with no line number on a changeset.
  • Viewed changeset.
    • Before patch: "Undefined index: <null>" error.
    • After patch: Clean changeset with lint message.

Screen Shot 2020-04-27 at 2.17.38 PM.png (236×856 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable