Differential D21151

Glue the new FormationView on top of the older Filetree view in Differential
ClosedPublic
Actions

Authored by epriestley on Apr 21 2020, 4:45 PM.

Details

Reviewers: None
Maniphest Tasks: T13516: Remove the "filetree" setting (so it's always enabled for everyone)
Commits: rP646280972b88: Glue the new FormationView on top of the older Filetree view in Differential

Summary

Ref T13516. This glues "FormationView" to "ChangesetList". The actual tree is not functional in any meaningful way yet.

Test Plan

Screen Shot 2020-04-21 at 9.41.58 AM.png (1×1 px, 329 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 21 2020, 4:45 PM

Harbormaster completed remote builds in B24178: Diff 50360.Apr 21 2020, 4:46 PM

epriestley requested review of this revision.Apr 21 2020, 4:46 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2020, 3:29 PM

Closed by commit rP646280972b88: Glue the new FormationView on top of the older Filetree view in Differential (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP646280972b88: Glue the new FormationView on top of the older Filetree view in Differential.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

src/

__phutil_library_map__.php

applications/

differential/

controller/

DifferentialRevisionViewController.php

45 lines

engine/

DifferentialFileTreeEngine.php

155 lines

view/

DifferentialChangesetListView.php

17 lines

view/

formation/

PHUIFormationColumnDynamicView.php

40 lines

PHUIFormationColumnItem.php

14 lines

PHUIFormationColumnView.php

16 lines

PHUIFormationFlankView.php

11 lines

PHUIFormationView.php

27 lines

webroot/

rsrc/

css/

phui/

phui-formation-view.css

6 lines

js/

application/

diff/

DiffChangesetList.js

29 lines

differential/

behavior-populate.js

18 lines

phui/

behavior-phuix-formation-view.js

phuix/

PHUIXFormationColumnView.js

49 lines

PHUIXFormationView.js

61 lines

Diff 50367

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

View Options

src/applications/differential/engine/DifferentialFileTreeEngine.php

View Options

src/applications/differential/view/DifferentialChangesetListView.php

View Options

src/view/formation/PHUIFormationColumnDynamicView.php

View Options

src/view/formation/PHUIFormationColumnItem.php

View Options

src/view/formation/PHUIFormationColumnView.php

View Options

src/view/formation/PHUIFormationFlankView.php

View Options

src/view/formation/PHUIFormationView.php

View Options

webroot/rsrc/css/phui/phui-formation-view.css

View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

View Options

webroot/rsrc/js/application/differential/behavior-populate.js

View Options

webroot/rsrc/js/phui/behavior-phuix-formation-view.js

View Options

webroot/rsrc/js/phuix/PHUIXFormationColumnView.js

View Options

webroot/rsrc/js/phuix/PHUIXFormationView.js

Glue the new FormationView on top of the older Filetree view in DifferentialClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50367

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/differential/controller/DifferentialRevisionViewController.php

src/applications/differential/engine/DifferentialFileTreeEngine.php

src/applications/differential/view/DifferentialChangesetListView.php

src/view/formation/PHUIFormationColumnDynamicView.php

src/view/formation/PHUIFormationColumnItem.php

src/view/formation/PHUIFormationColumnView.php

src/view/formation/PHUIFormationFlankView.php

src/view/formation/PHUIFormationView.php

webroot/rsrc/css/phui/phui-formation-view.css

webroot/rsrc/js/application/diff/DiffChangesetList.js

webroot/rsrc/js/application/differential/behavior-populate.js

webroot/rsrc/js/phui/behavior-phuix-formation-view.js

webroot/rsrc/js/phuix/PHUIXFormationColumnView.js

webroot/rsrc/js/phuix/PHUIXFormationView.js

Glue the new FormationView on top of the older Filetree view in Differential
ClosedPublic
Actions

Revision Contents
Changeset List