Page MenuHomePhabricator
Differential D21191

When users submit "editing" inlines, warn them that their inlines will be saved
ClosedPublic
Actions

Authored by epriestley on Apr 30 2020, 12:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 1, 3:06 AM
Unknown Object (File)
Mon, Apr 1, 2:11 AM
Unknown Object (File)
Mon, Apr 1, 2:11 AM
Unknown Object (File)
Mon, Apr 1, 2:11 AM
Unknown Object (File)
Mon, Apr 1, 2:11 AM
Unknown Object (File)
Sun, Mar 31, 6:57 PM
Unknown Object (File)
Fri, Mar 29, 12:18 AM
Unknown Object (File)
Mar 15 2024, 8:40 PM
View All 70 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13513: Make schema changes to inlines to prepare for new inline features
Commits
rP67da18e37478: When users submit "editing" inlines, warn them that their inlines will be saved
Summary

Ref T13513. This slightly expands the existing-but-hacky "warning" workflow to cover both "mentions on draft" and "submitting inlines being edited".

Test Plan
  • Submitted changes to a revision with mentions on a draft, inlines being edited, both, and neither.
  • Got sensible warnings in the cases where warnings were appropriate.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 30 2020, 12:15 AM
Harbormaster completed remote builds in B24283: Diff 50464.Apr 30 2020, 12:17 AM
epriestley requested review of this revision.Apr 30 2020, 12:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2020, 8:13 PM
Closed by commit rP67da18e37478: When users submit "editing" inlines, warn them that their inlines will be saved (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP67da18e37478: When users submit "editing" inlines, warn them that their inlines will be saved.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
storage/
40 lines
transactions/
data/
47 lines
editengine/
1 line
editor/
9 lines
exception/
4 lines
response/
116 lines
storage/
6 lines
infrastructure/
internationalization/
translation/
11 lines
webroot/
rsrc/
css/
aphront/
5 lines

Diff 50524

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
View Options

src/applications/transactions/data/PhabricatorTransactionWarning.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/exception/PhabricatorApplicationTransactionWarningException.php

Loading...
View Options

src/applications/transactions/response/PhabricatorApplicationTransactionWarningResponse.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
Phabricator · Built by Phacility