Page MenuHomePhabricator

When users submit "editing" inlines, warn them that their inlines will be saved
ClosedPublic

Authored by epriestley on Thu, Apr 30, 12:15 AM.

Details

Summary

Ref T13513. This slightly expands the existing-but-hacky "warning" workflow to cover both "mentions on draft" and "submitting inlines being edited".

Test Plan
  • Submitted changes to a revision with mentions on a draft, inlines being edited, both, and neither.
  • Got sensible warnings in the cases where warnings were appropriate.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Apr 30, 12:15 AM
epriestley requested review of this revision.Thu, Apr 30, 12:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, May 4, 8:13 PM
This revision was automatically updated to reflect the committed changes.