Page MenuHomePhabricator
Differential D21140

Move "External Editor" settings to a separate settings group
ClosedPublic
Actions

Authored by epriestley on Apr 18 2020, 4:56 PM.
Tags
None
Referenced Files
F18790561: D21140.id50337.diff
Wed, Oct 15, 3:32 PM
F18734242: D21140.id.diff
Tue, Sep 30, 10:50 PM
F18725893: D21140.diff
Tue, Sep 30, 5:59 AM
F18101013: D21140.diff
Aug 9 2025, 12:15 PM
F17933364: D21140.id.diff
Jul 30 2025, 9:11 PM
F17898405: D21140.diff
Jul 29 2025, 8:05 AM
F17672276: D21140.id50337.diff
Jul 13 2025, 3:12 AM
F17666211: D21140.diff
Jul 12 2025, 8:42 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13515: Differential: Inlines and View Options
Commits
rP84cd4a385450: Move "External Editor" settings to a separate settings group
Summary

Ref T13515. It's not intuitive that these settings are "Display Preferences", even thought they're intenrally related to some of the other display preferences.

Give them a separate group.

Test Plan

Screen Shot 2020-04-18 at 9.53.19 AM.png (1×1 px, 335 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 18 2020, 4:56 PM
Harbormaster completed remote builds in B24155: Diff 50337.Apr 18 2020, 4:57 PM
epriestley requested review of this revision.Apr 18 2020, 4:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 3:59 PM
Closed by commit rP84cd4a385450: Move "External Editor" settings to a separate settings group (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP84cd4a385450: Move "External Editor" settings to a separate settings group.

Revision Contents
Changeset List

Diff 50350

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorMultipleSetting.php

Loading...
View Options

src/applications/settings/setting/PhabricatorEditorSetting.php

Loading...
View Options

src/docs/user/userguide/external_editor.diviner

Loading...
Phabricator · Built by Phacility