Page MenuHomePhabricator

Update the diff table of contents to use hierarchical views and edit distance renames
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:23 PM.
Tags
None
Referenced Files
F18762156: D21183.diff
Mon, Oct 6, 5:47 PM
F18756050: D21183.id.diff
Sun, Oct 5, 8:55 AM
F18734272: D21183.id.diff
Tue, Sep 30, 10:51 PM
F18734159: D21183.id50446.diff
Tue, Sep 30, 10:49 PM
F18690177: D21183.id50445.diff
Fri, Sep 26, 7:16 PM
F18617528: D21183.diff
Sep 14 2025, 9:26 PM
F18110250: D21183.id.diff
Aug 11 2025, 5:39 PM
F18105298: D21183.diff
Aug 10 2025, 5:29 PM
Subscribers
None

Details

Summary

Ref T13520. Generally, make the table of contents look and more like the paths panel:

  • Show a hierarchy, with compression for single-sibling children.
  • Use the same icons, instead of "M D" and "(img)" stuff.
  • Use EditDistanceMatrix to do a piece-by-piece diff of paths changes.
  • Show path changes within the path list.

I'm not entirely sold on this, but it was complicated to write and I've never heard the term "sunk cost fallacy". I think this is mostly a net improvement, but may need some adjustments and followup.

Test Plan

Viewed various changes in Differential and Diffusion, saw a more usable table of contents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:27 PM
This revision was automatically updated to reflect the committed changes.