Page MenuHomePhabricator

Update the diff table of contents to use hierarchical views and edit distance renames
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 4:47 PM
Unknown Object (File)
Mon, Dec 16, 5:49 AM
Unknown Object (File)
Thu, Dec 5, 12:36 AM
Unknown Object (File)
Wed, Dec 4, 12:35 PM
Unknown Object (File)
Tue, Dec 3, 10:55 AM
Unknown Object (File)
Mon, Nov 25, 9:47 AM
Unknown Object (File)
Nov 20 2024, 9:25 PM
Unknown Object (File)
Nov 17 2024, 7:19 AM
Subscribers
None

Details

Summary

Ref T13520. Generally, make the table of contents look and more like the paths panel:

  • Show a hierarchy, with compression for single-sibling children.
  • Use the same icons, instead of "M D" and "(img)" stuff.
  • Use EditDistanceMatrix to do a piece-by-piece diff of paths changes.
  • Show path changes within the path list.

I'm not entirely sold on this, but it was complicated to write and I've never heard the term "sunk cost fallacy". I think this is mostly a net improvement, but may need some adjustments and followup.

Test Plan

Viewed various changes in Differential and Diffusion, saw a more usable table of contents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:27 PM
This revision was automatically updated to reflect the committed changes.