Page MenuHomePhabricator

Update the diff table of contents to use hierarchical views and edit distance renames
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:23 PM.
Tags
None
Referenced Files
F15373447: D21183.id50446.diff
Wed, Mar 12, 4:10 PM
F15316016: D21183.diff
Thu, Mar 6, 6:19 PM
Unknown Object (File)
Mon, Mar 3, 6:28 PM
Unknown Object (File)
Tue, Feb 25, 5:21 PM
Unknown Object (File)
Mon, Feb 24, 2:43 AM
Unknown Object (File)
Sat, Feb 22, 6:56 AM
Unknown Object (File)
Fri, Feb 21, 8:58 PM
Unknown Object (File)
Fri, Feb 21, 8:16 PM
Subscribers
None

Details

Summary

Ref T13520. Generally, make the table of contents look and more like the paths panel:

  • Show a hierarchy, with compression for single-sibling children.
  • Use the same icons, instead of "M D" and "(img)" stuff.
  • Use EditDistanceMatrix to do a piece-by-piece diff of paths changes.
  • Show path changes within the path list.

I'm not entirely sold on this, but it was complicated to write and I've never heard the term "sunk cost fallacy". I think this is mostly a net improvement, but may need some adjustments and followup.

Test Plan

Viewed various changes in Differential and Diffusion, saw a more usable table of contents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:27 PM
This revision was automatically updated to reflect the committed changes.