Page MenuHomePhabricator

Update the diff table of contents to use hierarchical views and edit distance renames
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:23 PM.
Tags
None
Referenced Files
F15447728: D21183.id50445.diff
Fri, Mar 28, 1:18 AM
F15442326: D21183.id50446.diff
Wed, Mar 26, 10:47 PM
F15437243: D21183.id.diff
Tue, Mar 25, 6:31 PM
F15432255: D21183.diff
Mon, Mar 24, 5:05 PM
F15430253: D21183.diff
Mon, Mar 24, 6:45 AM
F15382888: D21183.diff
Fri, Mar 14, 2:50 PM
F15373447: D21183.id50446.diff
Wed, Mar 12, 4:10 PM
F15316016: D21183.diff
Thu, Mar 6, 6:19 PM
Subscribers
None

Details

Summary

Ref T13520. Generally, make the table of contents look and more like the paths panel:

  • Show a hierarchy, with compression for single-sibling children.
  • Use the same icons, instead of "M D" and "(img)" stuff.
  • Use EditDistanceMatrix to do a piece-by-piece diff of paths changes.
  • Show path changes within the path list.

I'm not entirely sold on this, but it was complicated to write and I've never heard the term "sunk cost fallacy". I think this is mostly a net improvement, but may need some adjustments and followup.

Test Plan

Viewed various changes in Differential and Diffusion, saw a more usable table of contents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:27 PM
This revision was automatically updated to reflect the committed changes.