Page MenuHomePhabricator

Update the diff table of contents to use hierarchical views and edit distance renames
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 25 2026, 6:48 AM
Unknown Object (File)
Feb 25 2026, 1:56 AM
Unknown Object (File)
Feb 5 2026, 10:37 AM
Unknown Object (File)
Jan 9 2026, 1:31 PM
Unknown Object (File)
Jan 9 2026, 1:27 PM
Unknown Object (File)
Jan 9 2026, 1:22 PM
Unknown Object (File)
Dec 2 2025, 12:33 PM
Unknown Object (File)
Nov 17 2025, 1:03 PM
Subscribers
None

Details

Summary

Ref T13520. Generally, make the table of contents look and more like the paths panel:

  • Show a hierarchy, with compression for single-sibling children.
  • Use the same icons, instead of "M D" and "(img)" stuff.
  • Use EditDistanceMatrix to do a piece-by-piece diff of paths changes.
  • Show path changes within the path list.

I'm not entirely sold on this, but it was complicated to write and I've never heard the term "sunk cost fallacy". I think this is mostly a net improvement, but may need some adjustments and followup.

Test Plan

Viewed various changes in Differential and Diffusion, saw a more usable table of contents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:27 PM
This revision was automatically updated to reflect the committed changes.