Page MenuHomePhabricator

Update the diff table of contents to use hierarchical views and edit distance renames
ClosedPublic

Authored by epriestley on Apr 28 2020, 7:23 PM.
Tags
None
Referenced Files
F17803059: D21183.id.diff
Fri, Jul 25, 9:48 AM
F17798976: D21183.id50445.diff
Fri, Jul 25, 4:22 AM
F17760863: D21183.diff
Tue, Jul 22, 8:09 PM
F17666326: D21183.id50446.diff
Sat, Jul 12, 8:49 PM
Unknown Object (File)
Jun 29 2025, 6:51 AM
Unknown Object (File)
Jun 28 2025, 4:01 PM
Unknown Object (File)
May 30 2025, 12:23 AM
Unknown Object (File)
May 29 2025, 11:54 PM
Subscribers
None

Details

Summary

Ref T13520. Generally, make the table of contents look and more like the paths panel:

  • Show a hierarchy, with compression for single-sibling children.
  • Use the same icons, instead of "M D" and "(img)" stuff.
  • Use EditDistanceMatrix to do a piece-by-piece diff of paths changes.
  • Show path changes within the path list.

I'm not entirely sold on this, but it was complicated to write and I've never heard the term "sunk cost fallacy". I think this is mostly a net improvement, but may need some adjustments and followup.

Test Plan

Viewed various changes in Differential and Diffusion, saw a more usable table of contents.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 7:27 PM
This revision was automatically updated to reflect the committed changes.