Page MenuHomePhabricator

Remove the "Edit Multiple Files" external editor setting
ClosedPublic

Authored by epriestley on Apr 18 2020, 6:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 5:37 AM
Unknown Object (File)
Feb 18 2024, 9:53 PM
Unknown Object (File)
Jan 21 2024, 4:52 AM
Unknown Object (File)
Dec 27 2023, 12:02 AM
Unknown Object (File)
Dec 26 2023, 2:58 PM
Unknown Object (File)
Dec 25 2023, 7:09 PM
Unknown Object (File)
Dec 17 2023, 6:21 PM
Unknown Object (File)
Nov 30 2023, 4:13 AM
Subscribers
None

Details

Summary

Ref T13515. No callsites actually use this, most editors don't support it, it doesn't seem terribly useful for the ones that do, it makes template-based APIs for line-number substitution complicated, and we can probably just loop on window.open() anyway.

Test Plan

Grepped for affected symbols, found no more references. Loaded settings page, saw no more setting.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:02 PM
This revision was automatically updated to reflect the committed changes.