Page MenuHomePhabricator

Restore editor behavior to Diffusion and support "\" shortcut
ClosedPublic

Authored by epriestley on Apr 19 2020, 3:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 5, 11:12 AM
Unknown Object (File)
Wed, Apr 3, 3:56 AM
Unknown Object (File)
Wed, Apr 3, 3:56 AM
Unknown Object (File)
Tue, Apr 2, 3:24 AM
Unknown Object (File)
Mon, Apr 1, 12:35 AM
Unknown Object (File)
Jan 20 2024, 4:43 PM
Unknown Object (File)
Jan 16 2024, 5:48 PM
Unknown Object (File)
Jan 12 2024, 5:34 PM
Subscribers
None

Details

Summary

Ref T13515. This restores the "Open in Editor" behavior to Diffusion, and makes "\" work there.

The URI pattern is now sent as a structured template to the client, so the code will work properly if a file path contains "%l".

Test Plan
  • Clicked "Open in Editor" and pressed "\" in Diffusion when viewing a file.
  • Clicked a line, hit "\", got the file opened to that line.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2020, 4:41 PM
This revision was automatically updated to reflect the committed changes.