Page MenuHomePhabricator

Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
ClosedPublic

Authored by epriestley on Wed, Apr 29, 9:45 PM.

Details

Summary

Ref T13519. See https://discourse.phabricator-community.org/t/error-call-to-undefined-method-differentialchangesetquery-withphids/3816/.

Changesets do not have PHIDs, and the Query has no "withPHIDs()" method. The keys in the viewstate storage are (usually) IDs.

Test Plan
  • On a revision with Diff 1 and Diff 2 affecting the same file:
    • Viewed Diff 1.
    • Hid file A.
    • Viewed Diff 2.
  • Before patch: exception about call to "withPHIDs()", which does not exist for ChangesetQuery.
  • After patch: no exception. Also, file actually unhid, which is the correct behavior!

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Apr 29, 9:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Apr 29, 9:47 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.