Differential D21141
Make the "Keyboard Shortcuts" dialog in Differential less hideous Authored by epriestley on Apr 18 2020, 6:25 PM. Tags None Referenced Files
Subscribers
Details
Ref T13515. Adding "\" ("Open in External Editor") made this slighlty worse, but it was already pretty bad. Long ago the keys had a special style on them, but this got changed and dropped somewhere around D16568 -- although at the time, I think they still had a grey background (see T11654). Some later change removed this background. Put the background back and separate the keystrokes into groups. 
Diff Detail
Event TimelineComment Actions Looking at it now, it looks very nice, but there should probably be a way to navigate the groups by keyboard? Comment Actions (Then you'd need another keystroke to bring up the "Keyboard Reference Dialog Keyboard Reference", though, so you could get a list of the keys for navigating the groups!) It's not obvious to me that this dialog should be keyboard-navigable. My goal with keyboard shortcuts isn't to support use of Phabricator without a mouse: if using a mouse is difficult for you (for example, because you're blind or have limited dexterity which prevents you from using a mouse accurately as a pointing device) I think you're likely best served by real accessibility tools (VoiceOver, etc) that tackle this goal directly. Other pieces of Phabricator (like "aural" / "visual" elements) exist to support these systems. My expectation is that this dialog should generally be navigable with these tools. Instead, I'm trying to make Phabricator more comfortable to use for users who don't have any physical challenges using a mouse, but find keyboard commands more convenient for repeated/routine tasks. In my mind, reviewing the keyboard reference shouldn't be a high-frequency task for these users, since they'll identify the commands they want to use and then learn them quickly through repetition. |