Page MenuHomePhabricator
Create Task
Maniphest T7467

Consider giving deleted files a more prominent treatment in the changeset UI
Closed, ResolvedPublic
Actions

Description

Via IRC, a user reported that their coworkers sometimes find that they miss deleted files in changesets.

I tend to agree with this, and think it's worth looking at rendering deleted files in a way that's more eye-catching as you scroll through the diff. For example:

  • Render the "deleted" thing in red.
  • Maybe use colorful icons in the table of contents.

Related Objects

Event Timeline

epriestley created this task.Mar 5 2015, 5:19 PM
epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Differential.
epriestley added a subscriber: epriestley.
• chasemp awarded a token.Mar 5 2015, 5:19 PM
• jazzdan added a subscriber: • jazzdan.Mar 5 2015, 5:23 PM
chad claimed this task.Mar 5 2015, 5:24 PM
MarcLindenberg added a subscriber: MarcLindenberg.Mar 5 2015, 5:26 PM

Since we are in a situation where we have to maintain at least two different build systems added files are nearly as important as deleted files.
So i suggest treating added files similarly.

joshuaspence added a subscriber: joshuaspence.Mar 5 2015, 7:35 PM
• sshannin mentioned this in T7469: Handle folder copies/moves more gracefully.Mar 5 2015, 11:08 PM
eadler added a project: Restricted Project.Jul 7 2016, 4:59 PM
Herald added a subscriber: eadler. · View Herald TranscriptJul 7 2016, 4:59 PM
epriestley added a comment.Feb 10 2018, 7:47 PM

See also PHI356.

epriestley mentioned this in T13516: Remove the "filetree" setting (so it's always enabled for everyone).Apr 18 2020, 2:51 PM
epriestley closed this task as Resolved.Apr 22 2020, 8:51 PM

This is quite old and I'm not sure it's particularly relevant anymore. T13516 has made some related changes.

Herald added a subscriber: amckinley. · View Herald TranscriptApr 22 2020, 8:51 PM
Phabricator · Built by Phacility