Page MenuHomePhabricator

Consider giving deleted files a more prominent treatment in the changeset UI
Closed, ResolvedPublic


Via IRC, a user reported that their coworkers sometimes find that they miss deleted files in changesets.

I tend to agree with this, and think it's worth looking at rendering deleted files in a way that's more eye-catching as you scroll through the diff. For example:

  • Render the "deleted" thing in red.
  • Maybe use colorful icons in the table of contents.

Event Timeline

epriestley raised the priority of this task from to Low.
epriestley updated the task description. (Show Details)
epriestley added a project: Differential.
epriestley added a subscriber: epriestley.

Since we are in a situation where we have to maintain at least two different build systems added files are nearly as important as deleted files.
So i suggest treating added files similarly.

eadler added a project: Restricted Project.Jul 7 2016, 4:59 PM

This is quite old and I'm not sure it's particularly relevant anymore. T13516 has made some related changes.