Page MenuHomePhabricator

Refine more Differential review state behaviors
ClosedPublic

Authored by epriestley on Apr 23 2020, 5:10 PM.

Details

Summary

Ref T13516.

  • Add an "Add Comment" navigation anchor.
  • Make selection state more clear.
  • Make hidden state tidier and more clear.
  • Hide "View Options" in the hidden state to dodge all the weird behaviors it implies.
  • Click to select/deselect changesets.
  • When you open the view dropdown menu, then press "h", close the dropdown menu.
Test Plan

Fiddled with all these behaviors.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2020, 5:14 PM
This revision was automatically updated to reflect the committed changes.