Page MenuHomePhabricator
Feed Advanced Search

Dec 13 2016

epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

Can you browse to https://your.install.com/applications/view/PhabricatorFilesApplication/ and post a screenshot of the "Storage Engines" panel on that page? It should look a little bit like this (example from this install), although your settings are presumably different:

Dec 13 2016, 11:32 AM · Files, Documentation, Bug Report

Dec 12 2016

epriestley closed T4945: Subscribing users when they award tokens as Wontfix.

This doesn't seem to be going anywhere too fast so I'm just going to nuke it while I'm combing through old things rather than letting it collect dust forever.

Dec 12 2016, 11:36 PM · Tokens
lewellyn awarded T11989: Wage an endless war against HP Printer Fax Support a The World Burns token.
Dec 12 2016, 11:20 PM · Abuse
chad awarded T11989: Wage an endless war against HP Printer Fax Support a Evil Spooky Haunted Tree token.
Dec 12 2016, 11:16 PM · Abuse
epriestley updated subscribers of T11989: Wage an endless war against HP Printer Fax Support.

We scored our first kill today. @dgdfgdg slipped through our defenses in his initial volley, but we reacted quickly and the system automatically deflected his second salvo.

Dec 12 2016, 11:14 PM · Abuse
epriestley closed T4883: Customizing the default homepage for all users as Resolved.

T11957 is the modern followup for this.

Dec 12 2016, 10:38 PM · Dashboards (v2)
epriestley closed T4850: Defining policies for "Project Members" as Resolved.

At least in this use case, I believe things turned out alright without this policy.

Dec 12 2016, 10:34 PM · Restricted Project, Policy
epriestley closed T4806: Give installs more control over session expiry / prompt for reauth before taking security actions as Wontfix.

It's critical that we are addressing specific, plausible threat scenarios when implementing security protocols. This task currently lacks such a scenario.

Dec 12 2016, 10:20 PM · Restricted Project, Auth
epriestley closed T4448: Support symlinking phriction pages as Invalid.

This is pretty old and doesn't meet the requirements of a modern feature request (notably, clear definition of a root problem). Feel free to file a new request if this is still an issue. Particularly helpful would be discussion of why editing the page to say "Go see <other page>" is insufficient.

Dec 12 2016, 9:47 PM · Restricted Project, Phriction
epriestley closed T4439: Set up SPF records for domains we control as Resolved.

This got done at some point, I believe, since we have an SPF record now.

Dec 12 2016, 9:44 PM · Mail, Security
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel as Resolved.
  • Over time, we've drained the swamp to some degree on the default home page, by moving toward more useful defaults.
  • We implemented Dashboards. Although we'd like to improve them, they've allowed ambitious users to fix this themselves for some time.
  • See T11957 and M1473 for modern followups with a more concrete plan to lay this to rest.
  • See also T11132 for discussion of NUX-oriented changes, specifically.
Dec 12 2016, 9:30 PM · Restricted Project, Dashboards (v2)
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel, a subtask of T3979: Support logged out version of the home page, as Resolved.
Dec 12 2016, 9:30 PM · Phabricator
epriestley closed T3583: Fix the Swamp of Suck that is the home page content panel, a subtask of T4323: Scaling bug (for Chrome browser), as Resolved.
Dec 12 2016, 9:29 PM · Badge Awarded, Design
epriestley closed T2683: Improve the performance of Diffusion browse views as Resolved.

This is a billion years old now -- see, e.g., T11954 for more modern work.

Dec 12 2016, 9:21 PM · Diffusion
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers as Resolved.

"Blame Revision" was a freeform text field at Facebook (from before DiffCamp, even) where you were ideally supposed to enter the revision or commit that introduced the bug you're fixing, if you were fixing a bug introduced by some known change.

Dec 12 2016, 9:18 PM · Differential, Audit, Diffusion
epriestley closed T2542: Provide a link from revisions that are blamees to their blamers, a subtask of T1751: Consider ways to improve revert handling, as Resolved.
Dec 12 2016, 9:18 PM · Restricted Project, Differential, Diffusion
epriestley added a project to T2115: Back button support in Lightbox: Quicksand.
Dec 12 2016, 9:10 PM · Quicksand, Lightbox, Files
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

That Chrome change seems at least plausible as a root cause to me, but I definitely don't know enough about the Chrome internals to really hazard a guess.

Dec 12 2016, 6:46 PM · Bug Report
epriestley closed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:39 PM · Bug Report
epriestley added a revision to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden: Unknown Object (Differential Revision).
Dec 12 2016, 6:36 PM · Bug Report
epriestley closed T11999: Fatal on "Customize Menu..." on home as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:33 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Chrome 55 no longer scrolls to elements which are completely hidden to When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
epriestley added a revision to T11999: Fatal on "Customize Menu..." on home: Unknown Object (Differential Revision).
Dec 12 2016, 6:16 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Links to Task's messages don't scroll to the message on Chrome 55 to Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

See also https://code.google.com/p/chromium/issues/detail?id=473657 for earlier adventures in Chrome.

Dec 12 2016, 6:13 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my upstream report:

Dec 12 2016, 6:11 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my reduced test case for Chome 55:

Dec 12 2016, 5:55 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Oh, it reproduces for me.

Dec 12 2016, 5:31 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

This appears to be a bug in Chrome, because this fixes it:

Dec 12 2016, 5:31 PM · Bug Report
epriestley added a comment to T11998: Content flashes when loading pages in Chrome.

Specifically, I resolved it by just pushing everything.

Dec 12 2016, 5:06 PM
epriestley closed T11998: Content flashes when loading pages in Chrome as Resolved.

I think I had pushed new code to secure001 and then wandered off to do something else.

Dec 12 2016, 5:05 PM
epriestley updated subscribers of T11998: Content flashes when loading pages in Chrome.
Dec 12 2016, 11:43 AM
epriestley created T11998: Content flashes when loading pages in Chrome.
Dec 12 2016, 11:43 AM

Dec 11 2016

epriestley renamed T11957: Add MenuEngine to Home from Add PanelEngine to Dashboards to Add MenuEngine to Dashboards.
Dec 11 2016, 9:29 PM · Profile Menu Item, Dashboards
epriestley closed T11521: Request Review action should clear "accepted older" status as Resolved.

Oh, I think the edit to the title here is actually misleading, and the author in this scenario never used "Request Review" (this action is only available if the author has previously used "Plan Changes", which they did not appear to in this scenario).

Dec 11 2016, 9:06 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T11989: Wage an endless war against HP Printer Fax Support.

I have a not-so-bad version of this in mind but it seems that the printer faxers are too terrified of our advanced defenses to even attack us any more.

Dec 11 2016, 8:41 PM · Abuse
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 6:54 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:51 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:08 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11957: Add MenuEngine to Home: Unknown Object (Differential Revision).
Dec 11 2016, 5:03 PM · Profile Menu Item, Dashboards
epriestley closed T11980: Links to external systems as Wontfix.
  • Systems integrated with Doorkeeper (JIRA, Asana, some prototype GitHub support) already get URIs marked up.
  • The current JIRA integration does cover JIRA URIs in all remarkup systems, including Phriction and Maniphest, although you can not link to multiple JIRA installs until T6703, and you must use full URIs (if you use JIRA-123, it's possible that multiple linked installs have project namespaces called "JIRA"). It's possible we'll support this more naturally in the future, but not until after T6703, which is a very low priority.
  • Custom markup rules already supported (see P1157, P1209 for some examples), although you're on your own to write them. These are probably the best fit for your use case.
  • I believe needs for this sort of thing are often very specialized, so I do not currently plan to add any kind of generic, configurable remarkup rule that just matches arbitrary regexps against stuff and links them. You could write such a rule as an extension. One caveat to this is that we currently have bugtraq.url and bugtraq.logregex, which sort of work like this, except in a bad way. I'd like to remove them in the future, but there's an outside possibility that we'll replace them with a more flexible system like the one you describe.
Dec 11 2016, 4:56 PM · Remarkup, Feature Request
epriestley closed T11995: Fatal error while saving global default preferences as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · User Preferences, Bug Report
epriestley closed T11993: New install errors out before "run storage upgrade" message as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11993: New install errors out before "run storage upgrade" message.

Thanks!

Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley claimed T11993: New install errors out before "run storage upgrade" message.
Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11995: Fatal error while saving global default preferences.

Thanks! Yeah, this was just some editing/testing slop on my part. Your suggested fix is correct.

Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley claimed T11995: Fatal error while saving global default preferences.
Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley closed T11994: 'Affected files' doesn't work in 'Commits' Herald rules as Resolved.
Dec 11 2016, 3:18 PM · Bug Report (Needs Information)
epriestley added a revision to T11993: New install errors out before "run storage upgrade" message: Unknown Object (Differential Revision).
Dec 11 2016, 3:17 PM · Bug Report, Installing & Upgrading
epriestley added a revision to T11995: Fatal error while saving global default preferences: Unknown Object (Differential Revision).
Dec 11 2016, 3:17 PM · User Preferences, Bug Report
Info-Screen awarded Blog Post: Write, Review, Merge, Publish: Phabricator Review Workflow a Like token.
Dec 11 2016, 12:45 PM

Dec 10 2016

epriestley edited the content of Changelog.
Dec 10 2016, 1:03 AM
epriestley created 2016 Week 50 (Mid December).
Dec 10 2016, 1:02 AM

Dec 9 2016

epriestley added a project to T11990: Outline is invisible on submit buttons: Design.

@chad, it looks like we're just using the browser's default outline for buttons.

Dec 9 2016, 11:28 PM · Design, Bug Report
epriestley added a comment to T11990: Outline is invisible on submit buttons.

Okay, it does look invisible in Firefox. Is Firefox the browser you're using?

Dec 9 2016, 11:18 PM · Design, Bug Report
epriestley added a comment to T11990: Outline is invisible on submit buttons.

I can't reproduce tab order differing from visual order, either.

Dec 9 2016, 11:16 PM · Design, Bug Report
epriestley added a comment to T11990: Outline is invisible on submit buttons.

I can't reproduce this:

Dec 9 2016, 11:15 PM · Design, Bug Report
epriestley added a comment to M1473: Home PanelEngine.

I would remove the idea of a "global dashboard" as distinct from "top dashboard" -- we just look through both sections and pick the first dashboard we see, if any exist.

Dec 9 2016, 10:02 PM
epriestley added a comment to M1473: Home PanelEngine.

Also, maybe a good way to start is to do this:

Dec 9 2016, 9:54 PM
epriestley added a comment to M1473: Home PanelEngine.

(I guess a bad argument for having hard-coded home is that you can uninstall Dashboards. We could make it a mandatory app, though.)

Dec 9 2016, 9:50 PM
epriestley added a comment to M1473: Home PanelEngine.

That is, if you delete all of the dashboards from the menu that's fine, you just get hard-coded home.

Dec 9 2016, 9:48 PM
epriestley added a comment to M1473: Home PanelEngine.

Oh, my suggestion is this:

Dec 9 2016, 9:48 PM
epriestley added a comment to M1473: Home PanelEngine.

I think the short technical path forward is:

Dec 9 2016, 9:45 PM
epriestley added a comment to M1473: Home PanelEngine.

Well I'm planning to make you build everything so we can do whatever you want, pretty much.

Dec 9 2016, 9:41 PM
avivey awarded T11989: Wage an endless war against HP Printer Fax Support a Manufacturing Defect? token.
Dec 9 2016, 8:37 PM · Abuse
epriestley added a comment to T11989: Wage an endless war against HP Printer Fax Support.

If you are not an administrator and create a task with THE FAX SUPPORT NUMBER THAT SHALL NOT BE NAMED in the title or body, you will now be immediately logged out of all your sessions and your task will be quarantined.

Dec 9 2016, 7:37 PM · Abuse
epriestley added a revision to T11989: Wage an endless war against HP Printer Fax Support: Unknown Object (Differential Revision).
Dec 9 2016, 7:26 PM · Abuse
epriestley created T11989: Wage an endless war against HP Printer Fax Support.
Dec 9 2016, 7:25 PM · Abuse
epriestley added a comment to M1473: Home PanelEngine.

Sorry, had to drop the pup off at pup daycare.

Dec 9 2016, 6:14 PM
epriestley added a comment to M1473: Home PanelEngine.

The solution that I think is most promising is this:

Dec 9 2016, 5:17 PM
epriestley added a comment to M1473: Home PanelEngine.

sorry phone

Dec 9 2016, 5:08 PM
epriestley added a comment to M1473: Home PanelEngine.

I don't think there's any reason that model can't work, it just feels really weird/inconsistent to me and not necessary, since I don't think there's any real value in retaining "install dashboard" or having a single magic home dashboard.

Dec 9 2016, 5:06 PM
epriestley added a comment to M1473: Home PanelEngine.

Also, is Dashboards going to get a second action so you have this choice when viewing a dashboard?

Dec 9 2016, 5:05 PM
epriestley added a comment to M1473: Home PanelEngine.

Okay, but I can end up with two different dashboard menu items which look the same, work the same, but are edited in completely different ways through entirely separate applications?

Dec 9 2016, 5:03 PM
epriestley added a comment to M1473: Home PanelEngine.

Also, if the user can't reorder, rename or remove Home, how do we figure out where it goes if they edit their menu and reorganize all the items (e.g., add three copies of their profile, all at the bottom of their favorites)?

Dec 9 2016, 4:57 PM
epriestley added a comment to M1473: Home PanelEngine.

If we retain "Install Dashboard", there are also two different ways to install a dashboard: to install a default dashboard, you go to Dashboards > blah blah > Install Dashboard. To install a second dashboard that you just want to be able to switch to, you go to "Customize Favorites > New Dashboard > ...". Seems potentially simpler to throw away "install dashboard" completely and just work like more like searches do.

Dec 9 2016, 4:49 PM
epriestley added a comment to M1473: Home PanelEngine.

If I install a custom personal dashboard, my personal dashboard becomes Home, replacing the existing "Home" link, and I can't get back to the global home?

Dec 9 2016, 4:47 PM
epriestley closed T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as Resolved by committing Restricted Diffusion Commit.
Dec 9 2016, 4:35 PM · Config, Bug Report
epriestley closed T11553: Add various "make an HTTP call" setup checks, and run them in parallel as Resolved.

I think we now test everything we've seen except RocketLoader (which is hard to test and hasn't come up too much recently) and not serving .whatever paths (which we've only ever seen one instance of, and which is also somewhat hard to test). I'm going to consider this resolved for now until we see more issues.

Dec 9 2016, 4:33 PM · Setup
epriestley closed T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS as Resolved by committing Restricted Diffusion Commit.
Dec 9 2016, 4:32 PM · Documentation, Setup
epriestley closed T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS, a subtask of T11553: Add various "make an HTTP call" setup checks, and run them in parallel, as Resolved.
Dec 9 2016, 4:32 PM · Setup
epriestley added a revision to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site: Unknown Object (Differential Revision).
Dec 9 2016, 4:22 PM · Config, Bug Report
epriestley reopened T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as "Open".

That's similar but not directly related.

Dec 9 2016, 4:18 PM · Config, Bug Report
epriestley closed T11955: Tag autocomplete doesn't always include milestones as Resolved by committing Restricted Diffusion Commit.
Dec 9 2016, 4:06 PM · Projects
epriestley added a revision to T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS: Unknown Object (Differential Revision).
Dec 9 2016, 4:05 PM · Documentation, Setup
rafaelrabeloit awarded T9640: Make Phabricator compatible with PHP7 a Like token.
Dec 9 2016, 3:53 PM · Prioritized, Restricted Project, Infrastructure
epriestley closed T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site as Resolved by committing Restricted Diffusion Commit.
Dec 9 2016, 3:51 PM · Config, Bug Report
epriestley added a comment to M1473: Home PanelEngine.

(Since we no longer have labels, can users add labels if they want?)

Dec 9 2016, 3:45 PM
epriestley added a comment to M1473: Home PanelEngine.

So they can remove "Home" and have no way to return to the install's default dashboard, and everyone has their own personal copy of "Home"?

Dec 9 2016, 3:44 PM
epriestley added a comment to T11978: Storage Tools Not Actually Upgrading Database.

That's correct. I'm not sure what's going wrong. My guesses are the crazy stuff you might expect like:

Dec 9 2016, 2:14 PM · Bug Report (Needs Information)
epriestley added a comment to T11955: Tag autocomplete doesn't always include milestones.

If you have project "AAA" with milestone "BBB", which renders as "AAA (BBB)" in the UI:

Dec 9 2016, 2:12 PM · Projects
epriestley added a revision to T11955: Tag autocomplete doesn't always include milestones: Unknown Object (Differential Revision).
Dec 9 2016, 2:11 PM · Projects
epriestley added a comment to T11955: Tag autocomplete doesn't always include milestones.

Actually, I think the issue @jcox reported and the downstream issue (https://phabricator.wikimedia.org/T152726) may not quite be the same.

Dec 9 2016, 2:02 PM · Projects
epriestley closed T6709: Update server requirements in docs, a subtask of T11553: Add various "make an HTTP call" setup checks, and run them in parallel, as Resolved.
Dec 9 2016, 1:52 PM · Setup
epriestley closed T6709: Update server requirements in docs as Resolved.

I'm going to close this as resolved because we now have a setup check for it and haven't seen any more Apache version issues since this report (more than two years).

Dec 9 2016, 1:52 PM · Documentation
epriestley closed T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character as Invalid.

I'm going to close this since it isn't reproducible (e.g., the link above works fine) and I'm fairly confident that this is a configuration problem in how you've adjusted nginx to work, deviating from the upstream instructions.

Dec 9 2016, 1:50 PM · Bug Report
epriestley added a comment to T11955: Tag autocomplete doesn't always include milestones.

It's also safe to cherry-pick whatever D17012 lands as and then reindex to pick this up immediately without doing a full upgrade.

Dec 9 2016, 1:39 PM · Projects
epriestley updated subscribers of T11955: Tag autocomplete doesn't always include milestones.

For best results (or maybe "any results"), run this command after upgrading past D17012:

Dec 9 2016, 1:36 PM · Projects
epriestley added a revision to T11955: Tag autocomplete doesn't always include milestones: Unknown Object (Differential Revision).
Dec 9 2016, 1:34 PM · Projects
epriestley added a comment to T11982: Preventing users from seeing your custom logo prevents them from seeing the whole site.

The "Public" vs "All Users" stuff is sort of a confusing behavior on our part (the workflow is what set "Public", which doesn't really make sense given the rest of your config) but I think it's largely mooted by the fix in D17011, and to be more clear about it we'd have to make this one particular file magical somehow (we can't choose either "users" or "public" as the policy unambiguously, because the install may change the value of policy.allow-public later without also updating the logo).

Dec 9 2016, 1:01 PM · Config, Bug Report