Maniphest T11961

DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	nickhutchinson
	Dec 7 2016, 10:28 PM

Description

Repro steps

Create a new Git branch with a "/" character, e.g. "foo/bar"; push it to a Phabricator-hosted repo
In Diffusion, browse to the repo, scroll to the "branches" section, click on the "foo/bar" link.

Expected behaviour

Phabricator displays the contents of the branch.

Actual behaviour

Unhandled Exception ("DiffusionRefNotFoundException")
Ref "foo" does not exist in this repository.

Version info

phabricator ad65d933fa75a2c417ba23f3684f0109de0f6ace (Sat, Dec 3)
arcanist e17fe43ca3fe6dc6dd0b5ce056f56310ea1d3d51 (Oct 22 2016)
phutil 3230179f3ce5d144a5fcdd5d68375f285006bd58 (Sat, Dec 3)

Related Objects

Mentioned In: T6709: Update server requirements in docs
rGITTESTeafe7aa04f2d: Test for T11961.
Mentioned Here: D12622: Add a wide range of HTTP-request-based setup checks
T11553: Add various "make an HTTP call" setup checks, and run them in parallel
rARCe17fe43ca3fe: (stable) Promote 2016 Week 43
rPad65d933fa75: (stable) Promote 2016 Week 49
rPHU3230179f3ce5: (stable) Promote 2016 Week 49

Event Timeline

nickhutchinson created this task.Dec 7 2016, 10:28 PM

Can you show me:

the RewriteRule entries in your httpd.conf; and
the output of httpd -v (or similar)?

We use nginx:

$ nginx -v
nginx version: nginx/1.10.2

/etc/nginx/sites-available/phabricator

client_max_body_size 32M;

map $http_upgrade $connection_upgrade {
    default upgrade;
    '' close;
}

server {
    server_name phabricator.mycompany.com phabricatorusercontent.mycompany.com;
    root        /srv/phabricator/phabricator/webroot;

    location / {
        try_files $uri /index.php?__path__=$uri&$query_string;
    }

    location = /favicon.ico {
        try_files $uri =204;
    }

    location = /index.php {
        if ($args !~ __path__) {
          set $args __path__=$uri&$query_string;
        }
        fastcgi_pass unix:/var/run/php-fpm/www.sock;
        fastcgi_index index.php;
        include fastcgi_params;
    }

    location = /ws/ {
        proxy_pass http://127.0.0.1:22280;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection $connection_upgrade;
    }
}

The problematic URLs look like this:

http://phabricator.mycompany.com/diffusion/MYREPO/browse/foo%252Fbar/

epriestley mentioned this in rGITTESTeafe7aa04f2d: Test for T11961..Dec 8 2016, 1:27 PM

Your config looks very little like the config we recommend. Why are you using try_files instead of rewrite?

When your webserver is configured correctly, branch names containing slashes should work properly. I believe you've deviated from the documented configuration in a way that changes behavior for URI-escaped parameters.

Here's an example of this working correctly on this server:

https://secure.phabricator.com/diffusion/GITTEST/browse/foo%252Fbar/

DiffusionRefNotFoundException when displaying a branch containing a slash ("/") characterClosed, InvalidPublicActions