Page MenuHomePhabricator

Tag autocomplete doesn't always include milestones
Closed, ResolvedPublic

Assigned To
None
Authored By
jcox
Dec 6 2016, 12:23 PM
Referenced Files
F2081698: pasted_file
Dec 6 2016, 12:23 PM
F2081700: pasted_file
Dec 6 2016, 12:23 PM
F2081695: pasted_file
Dec 6 2016, 12:23 PM

Description

Repro Steps

  1. Create a project with a multi-word title (ie. "COOL PROJECT" (because it's cool))
  2. Create a milestone under that project. Name it anything you'd like ("Sprint 1" in this example)
  3. Go to the "New Task" form.
  4. In the "Tags" field, type Coo

Expected Result: The autocomplete list should contain both "COOL PROJECT" and "COOL PROJECT (Sprint 1)"
Actual Result: The autocomplete list only contains "COOL PROJECT"

However, if you begin typing the second word of your project's title, the milestone does appear in the results. This then gets cached on the front end, so subsequent attempts at typing in the first word do display the milestone. See the screenshots below if that's unclear:

First:

pasted_file (159×364 px, 10 KB)

Second:

pasted_file (139×412 px, 16 KB)

Third:

pasted_file (167×362 px, 14 KB)

Another related issue: I don't think it's possible to get milestones to show up in the autocomplete if the parent project's title is only a single word.

Event Timeline

jcox updated the task description. (Show Details)
jcox raised the priority of this task from Normal to Needs Triage.Dec 6 2016, 12:28 PM

+ @aklapper / @20after4

For best results (or maybe "any results"), run this command after upgrading past D17012:

phabricator/ $ ./bin/search index --type project --force

That should complete quickly (a few seconds) and make milestones work properly.

It's also safe to cherry-pick whatever D17012 lands as and then reindex to pick this up immediately without doing a full upgrade.

Actually, I think the issue @jcox reported and the downstream issue (https://phabricator.wikimedia.org/T152726) may not quite be the same.

If you have project "AAA" with milestone "BBB", which renders as "AAA (BBB)" in the UI:

  • Searching for "BBB" will find the milestone after D17012 + reindex.
  • Searching for "AAA" will find the milestone after D17013 (no reindex required).