Page MenuHomePhabricator
Create Task
Maniphest T11553

Add various "make an HTTP call" setup checks, and run them in parallel
Closed, ResolvedPublic
Actions

Description

We have several setup checks we'd like to perform that require making an HTTP request to some service (usually, localhost).

We'll execute these with short timeouts, but we'd be better off running these in parallel than in series. See subtasks for details.

  • (T2226) Test gzip settings.
  • (T11544) Detect "burstable CPU" AWS instances.
  • (T5067) Test missing "B" flag in Apache rewrite rules.
    • (T6709) Mentions a documentation change.
  • (T4854) Test for mod_pagespeed.
    • Also, test for Rocket Loader?
  • (T10597) Possibly test for webservers not serving /.* paths, although we only ever saw one report of that.
  • (T6866) Test for missing QSA rules.
  • (T4921) Test for Basic authorization not being forwarded.
  • Test for leading or trailing whitespace caused by <space><newline><?php or ?><spaces and newlines>.

Revisions and Commits

rP Phabricator
D12622rPffdc082852fe Add a wide range of HTTP-request-based setup checks

Related Objects
Search...

Event Timeline

epriestley created this task.Aug 29 2016, 4:21 PM
Herald added a subscriber: eadler. · View Herald TranscriptAug 29 2016, 4:21 PM
epriestley added subtasks: T2226: Include a setup test for gzip enabled on the server, T4921: Detect when webserver configuration does not forward HTTP authorization, T6866: Add setup check for missing QSA in rewrite rules, T6709: Update server requirements in docs, T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS, T4854: Detect mod_pagespeed and warn the user, or don't break when it is enabled, T5067: Can't browse or see history of any files with a '+' in the file path., T10597: Custom Project query results in . url which nginx blocks.Aug 29 2016, 4:22 PM
epriestley mentioned this in T11571: Consider benchmarking hardware during setup.Sep 1 2016, 2:24 PM
epriestley mentioned this in T11587: Explicit "Host: domain.com:80" port may conflict with reasonable Host-based redirection rules.Sep 5 2016, 1:44 PM
epriestley mentioned this in T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.Dec 8 2016, 1:30 PM
epriestley updated the task description. (Show Details)Dec 8 2016, 8:37 PM
epriestley added a revision: D12622: Add a wide range of HTTP-request-based setup checks.Dec 8 2016, 11:37 PM
epriestley added a commit: rPffdc082852fe: Add a wide range of HTTP-request-based setup checks.Dec 8 2016, 11:46 PM
epriestley closed subtask T6866: Add setup check for missing QSA in rewrite rules as Resolved.
epriestley closed subtask T4921: Detect when webserver configuration does not forward HTTP authorization as Resolved.
epriestley closed subtask T4854: Detect mod_pagespeed and warn the user, or don't break when it is enabled as Resolved.
epriestley closed subtask T2226: Include a setup test for gzip enabled on the server as Resolved.
epriestley closed subtask T6709: Update server requirements in docs as Resolved.Dec 9 2016, 1:52 PM
epriestley closed subtask T11544: Add a setup warning about using "Burstable CPU" (T2) instance classes in AWS as Resolved.Dec 9 2016, 4:32 PM
epriestley closed this task as Resolved.Dec 9 2016, 4:33 PM
epriestley claimed this task.

I think we now test everything we've seen except RocketLoader (which is hard to test and hasn't come up too much recently) and not serving .whatever paths (which we've only ever seen one instance of, and which is also somewhat hard to test). I'm going to consider this resolved for now until we see more issues.

Phabricator · Built by Phacility