Page MenuHomePhabricator
Feed Advanced Search

Dec 9 2015

epriestley updated the task description for T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.
Dec 9 2015, 3:05 PM · Maniphest, Installing & Upgrading
epriestley closed T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events as Resolved by committing Restricted Diffusion Commit.
Dec 9 2015, 3:03 PM · Modernization, Maniphest
epriestley closed T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events, a subtask of T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed, as Resolved.
Dec 9 2015, 3:03 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9851: Remove TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK events.

Tech changes out of T9132 (see also T9905) put this on a relatively short timetable and this stuff is no longer active on the major edit workflows so I'm going to land T9860. We probably won't cut a stable this week, and will continue issuing guidance on upgrading smoothly through these changes.

Dec 9 2015, 3:02 PM · Modernization, Maniphest
epriestley closed T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden as Resolved by committing Restricted Diffusion Commit.
Dec 9 2015, 2:59 PM · Transactions
epriestley added a comment to T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden.

Specifically, the rule is that the lesser of:

Dec 9 2015, 2:59 PM · Transactions
epriestley added a comment to T9938: Maniphest Actions are improperly disabled/can lead to 404.

I couldn't include F1018337 in the original post?

Dec 9 2015, 2:51 PM · Bug Report
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Additional errata:

Dec 9 2015, 2:50 PM · ApplicationEditor
epriestley added a revision to T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden: Unknown Object (Differential Revision).
Dec 9 2015, 2:45 PM · Transactions
epriestley added a comment to T6884: Logging when a task has been marked as a blocker.

"Create Subtask" is a shortcut for "Create Task, then add it as a blocker for this one".

Dec 9 2015, 2:33 PM · Transactions, Maniphest
epriestley updated subscribers of T6884: Logging when a task has been marked as a blocker.
Dec 9 2015, 2:32 PM · Transactions, Maniphest
epriestley merged task T6672: Add transaction to the parent task when a subtask gets added via "Create Subtask" into T6884: Logging when a task has been marked as a blocker.
Dec 9 2015, 2:32 PM · Transactions, Maniphest
epriestley removed a project from T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog: Transactions.
Dec 9 2015, 2:31 PM · Maniphest
epriestley moved T9132: Build an ApplicationEditor abstraction from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:30 PM · Restricted Project, ApplicationEditor, Transactions
epriestley moved T9527: Confusing "... shifted this object from the S1 Public space to..." from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:30 PM · Transactions
epriestley moved T7661: Object creation is often accompanied by transaction records which aren't of much use from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:29 PM · Transactions, Maniphest
epriestley moved T9077: Some applications don't support the "Quote" action on comments properly from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:29 PM · Restricted Project, Transactions
epriestley moved T9920: Be able to set the sort of the transaction log or set when older changes need to be hidden from Backlog to vNext on the Transactions board.
Dec 9 2015, 2:29 PM · Transactions
epriestley added a comment to T9527: Confusing "... shifted this object from the S1 Public space to...".

T7661 is also similar.

Dec 9 2015, 2:29 PM · Transactions
epriestley removed a project from T5529: Clear Flags on Accept: Herald.
Dec 9 2015, 1:38 PM · Flags
epriestley moved T6207: Add a "Can Use Herald Rules" application permission from Backlog to Next on the Herald board.
Dec 9 2015, 1:37 PM · Restricted Project, Policy, Herald
epriestley moved T7804: Implement an "Acting User" Herald condition from Backlog to Next on the Herald board.
Dec 9 2015, 1:37 PM · Restricted Project, Herald, Mail
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Actually, that report is already fixed.

Dec 9 2015, 1:35 PM · Documentation, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Actually, that report is already fixed. For completeness, the behavior adapters should have is:

Dec 9 2015, 1:34 PM · Documentation, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

See also T7961, which is another modular behavior adapters should have.

Dec 9 2015, 1:33 PM · Documentation, Herald
epriestley moved T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules from Backlog to Next on the Herald board.
Dec 9 2015, 1:33 PM · Applications, Herald
epriestley closed T8682: Commit hooks should have better notification options for committers as Wontfix.
  • You can now technically write this as an extension by extending HeraldAction, although mail is quite complicated and this extension may be challenging to write.
  • You could use an extension like the one in P1895 to add a comment instead, although I think this will be caught by notification preferences.
  • You can use the action above (reject commit unless they bypass).
  • You could use "Add Projects" and then just manually email the offenders who got hit at the end of the week to warn them.
Dec 9 2015, 1:32 PM · Notifications, Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

Offhand, I'm inclined to still publish "Herald closed the task." in the "subscribe + close" hypothetical, which I think is the current behavior.

Dec 9 2015, 1:26 PM · Feed, Herald
epriestley added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

This behavior is "correct" in some sense (Herald really did perform the "strongest" action in the transaction group) but the sorting on tiebreakers is likely wrong (see D14680 for a similar case) and we should sort actions by real users over actions by Herald at the same strength.

Dec 9 2015, 1:24 PM · Feed, Herald
epriestley moved T8952: Hide "Herald added subscribers..." stories from feed completely from Backlog to Next on the Herald board.
Dec 9 2015, 1:16 PM · Feed, Herald
epriestley closed T9071: Herald rule supports Differential Revision dependent processing as Wontfix.

The build for Dyyyy should not fail. They do not fail in the upstream.

Dec 9 2015, 1:16 PM · Differential, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Related, the test console has a big if ($x instanceof ...) mess that should be pushed down into Adapters. A reasonable flow might be:

Dec 9 2015, 1:14 PM · Documentation, Herald
epriestley renamed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess from Herald test console doesn't appear to work for commit hooks (pre-receive) to Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Dec 9 2015, 1:12 PM · Documentation, Herald
epriestley moved T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess from Backlog to Next on the Herald board.
Dec 9 2015, 1:12 PM · Documentation, Herald
epriestley closed T9700: Change maniphest tasks depending on project memberships. as Wontfix.

The new tools from T9132 are now in HEAD (see D14718 for documentation, which will land shortly).

Dec 9 2015, 1:11 PM · Herald
epriestley added a comment to T5031: Draft Comment Persists After Submission.

Broadly, if comments have the new "stacked action" UI (an "Add Action..." dropdown, allowing you to take multiple actions at once), the expectation is that they support the new drafts too. This includes Maniphest at HEAD.

Dec 9 2015, 1:05 PM · Restricted Project, Support Impact, Mobile
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 9 2015, 1:01 PM · Restricted Project, ApplicationEditor, Transactions
epriestley closed T9939: bin/drydock lease doesn't work at all any more as Invalid.

I can't reproduce this issue by following the steps in the report:

Dec 9 2015, 10:14 AM · Drydock, Bug Report
joshuaspence added projects to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff: Arcanist, Harbormaster.
Dec 9 2015, 10:07 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
joshuaspence added projects to T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed: Arcanist, Harbormaster.
Dec 9 2015, 10:02 AM · Harbormaster, Arcanist, Restricted Project, Bug Report
joshuaspence added a project to T9939: bin/drydock lease doesn't work at all any more: Drydock.
Dec 9 2015, 8:49 AM · Drydock, Bug Report
epriestley added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

These unit tests take a while. I'll run it on the final revision

Dec 9 2015, 1:08 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 9 2015, 12:57 AM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 9 2015, 12:53 AM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 9 2015, 12:48 AM · ApplicationEditor
epriestley added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

(See general churn in T9905, T9908, T9132.)

Dec 9 2015, 12:34 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

Oh -- are you creating these from the workboard? Never mind, in that case.

Dec 9 2015, 12:34 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley added a comment to T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff.

I don't understand the difference between this and T9936. Aren't they aiming to solve the same problem (difficulty remembering what failed during arc diff when running arc land)?

Dec 9 2015, 12:33 AM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley added a comment to T9936: During arc land harbormaster failure, cannot tell if "arc lint" or "arc unit" failed.

The expectation is that you'll remember what the issue was, since arc diff printed the specific problems earlier and you already explicitly confirmed that you wanted to continue despite the issues.

Dec 9 2015, 12:27 AM · Harbormaster, Arcanist, Restricted Project, Bug Report
epriestley moved T9935: Split ~/.arcrc between machine and user config from Backlog to Far Future on the Arcanist board.
Dec 9 2015, 12:09 AM · Arcanist, Feature Request
epriestley triaged T9935: Split ~/.arcrc between machine and user config as Wishlist priority.

As a workaround, you might be able to put aliases in /etc/arcconfig (e.g., symlink that to something which is version controlled) and use ~/.arcconfig for credentials only.

Dec 9 2015, 12:09 AM · Arcanist, Feature Request

Dec 8 2015

epriestley reassigned T6064: One-Click Add Task on Workboard Columns from epriestley to chad.

After "thinking carefully" about this I am going to do the lazy / less bold approach and we can sort it out later so you can have this back. :3

Dec 8 2015, 11:30 PM · Restricted Project, Workboards
epriestley closed T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly as Resolved by committing Restricted Diffusion Commit.
Dec 8 2015, 11:29 PM · Maniphest
epriestley added a comment to T6064: One-Click Add Task on Workboard Columns.

("Not really." in the sense of "I don't have anything in mind" -- I agree that it might feel weird.)

Dec 8 2015, 11:25 PM · Restricted Project, Workboards
epriestley added a comment to T6064: One-Click Add Task on Workboard Columns.

Not really. I was going to do this:

Dec 8 2015, 11:23 PM · Restricted Project, Workboards
epriestley claimed T6064: One-Click Add Task on Workboard Columns.

I'm going to try to bludgeon this in for EditEngine, we can refine it in Projects v3 if I ham it up.

Dec 8 2015, 11:19 PM · Restricted Project, Workboards
epriestley moved T6064: One-Click Add Task on Workboard Columns from Backlog to Workboards v2 on the Workboards board.
Dec 8 2015, 11:17 PM · Restricted Project, Workboards
epriestley moved T6502: Policy to define who can move cards in a workboard from Backlog to Workboards v2 on the Workboards board.
Dec 8 2015, 11:17 PM · Projects, Wikimedia, Policy, Workboards
epriestley closed T9089: Clicking "Edit column" should provide user feedback as Resolved.

I think D14016 actually fixed this?

Dec 8 2015, 11:12 PM · Workboards
epriestley closed T8596: Let (some?) users hide the default column in a workboard as Wontfix.

I don't plan to implement this. We haven't seen other interest in it and your use case seems fairly unusual.

Dec 8 2015, 11:11 PM · Workboards
epriestley closed T9520: Allow Workboards to show a thumbnail image within each card as Invalid.

See Contributing Feature Requests for help writing a feature request.

Dec 8 2015, 11:08 PM · Workboards
epriestley moved T5214: Add Conduit API methods for workboards from Test to Workboards v2 on the Workboards board.
Dec 8 2015, 11:06 PM · Restricted Project, Conduit, Maniphest, Workboards
epriestley added projects to T5214: Add Conduit API methods for workboards: Maniphest, Conduit.
Dec 8 2015, 11:03 PM · Restricted Project, Conduit, Maniphest, Workboards
epriestley moved T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges from Backlog to vNext on the Conduit board.
Dec 8 2015, 10:53 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley moved T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings from Backlog to vNext on the Conduit board.
Dec 8 2015, 10:53 PM · Restricted Project, Auth, Conduit
epriestley moved T9063: Conduit application search from Backlog to vNext on the Conduit board.
Dec 8 2015, 10:52 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley moved T7991: Show deprecated Conduit method call warning to users from Backlog to vNext on the Conduit board.
Dec 8 2015, 10:51 PM · Conduit
epriestley removed a project from T9319: Accessing image file in Diffusion must not generate error (unhandled exception): Conduit.
Dec 8 2015, 10:51 PM · Phacility, Diffusion, Phacility Support
epriestley moved T9755: Have conduit call logs actually log the caller from Backlog to vNext on the Conduit board.
Dec 8 2015, 10:51 PM · Conduit
epriestley moved T7303: Provide OAuth access to Conduit from Backlog to Future on the Conduit board.
Dec 8 2015, 10:50 PM · Restricted Project, Conduit, Restricted Project
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 8 2015, 10:47 PM · ApplicationEditor
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 8 2015, 10:32 PM · ApplicationEditor
epriestley added a revision to T8903: Removing projects by editing a task in-place from a query result list doesn't refresh properly: Unknown Object (Differential Revision).
Dec 8 2015, 10:32 PM · Maniphest
epriestley added a comment to T9935: Split ~/.arcrc between machine and user config.

Do you have a meaningful amount of configuration in your ~/.arcrc?

Dec 8 2015, 10:09 PM · Arcanist, Feature Request
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 8 2015, 8:54 PM · ApplicationEditor
epriestley renamed T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag from Support download tag archive file to Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag.
Dec 8 2015, 5:24 PM · Drydock, Diffusion
epriestley updated subscribers of T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag.
Dec 8 2015, 5:19 PM · Drydock, Diffusion
epriestley merged task T9934: Add support for downloading zip files or compressed files into T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag.
Dec 8 2015, 5:19 PM · Diffusion, Differential, Feature Request
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 8 2015, 4:12 PM · ApplicationEditor
epriestley added a comment to T9926: SVN Commit fails, hard to debug.

(If your time is valuable, we're happy to shoulder the entire burden of building a reproduction case and fish around for environmental problems at our consulting rate; see Consulting.)

Dec 8 2015, 3:39 PM · Bug Report (Needs Information), Subversion, Diffusion
epriestley added a comment to T9926: SVN Commit fails, hard to debug.

Or, let me clarify: if you give us a running VM in EC2 with root credentials, that's useful.

Dec 8 2015, 3:37 PM · Bug Report (Needs Information), Subversion, Diffusion
epriestley added a comment to T9926: SVN Commit fails, hard to debug.

If I could provide a virtual machine image of some sort that shows the issue, would that be useful?

Dec 8 2015, 3:34 PM · Bug Report (Needs Information), Subversion, Diffusion
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 8 2015, 3:03 PM · ApplicationEditor
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 8 2015, 2:19 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 8 2015, 2:19 PM · ApplicationEditor
epriestley updated subscribers of T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).
Dec 8 2015, 2:15 PM · Guides, Doorkeeper
epriestley merged task T9921: Be able to execute a partial text search for custom Maniphest field into T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.).
Dec 8 2015, 2:15 PM · Custom Fields
epriestley added a comment to T9933: Strange elasticsearch mapping types for unix epoch dates.

When submitting a feature request, please describe the root problem you are trying to solve. See Contributing Feature Requests.

Dec 8 2015, 1:55 PM · Elasticsearch, Feature Request
epriestley added a comment to T9933: Strange elasticsearch mapping types for unix epoch dates.

Can you provide more details on exactly how this is a bug?

Dec 8 2015, 1:27 PM · Elasticsearch, Feature Request
epriestley closed T9932: Split ~/.arcrc between secret and public configs as Invalid.

This does not describe a bug with Phabricator. For help filing a bug, see Contributing Bug Reports.

Dec 8 2015, 1:19 PM · Arcanist, Bug Report
epriestley added a comment to T9924: Add support for git worktree.

So - a technical team lead would encounter this.

Dec 8 2015, 10:14 AM · FreeBSD, Restricted Project, Arcanist, Feature Request
epriestley changed the visibility for T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Dec 8 2015, 10:12 AM · Arcanist
epriestley merged task T9929: arc diff/export generate wrong GIT patch when file is deleted and then create a same name symbol link file. into T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Dec 8 2015, 10:12 AM · Arcanist
epriestley updated subscribers of T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Dec 8 2015, 10:12 AM · Arcanist
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 8 2015, 1:21 AM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 8 2015, 1:21 AM · ApplicationEditor
epriestley added a comment to T9923: Phabricator favicon not showing despite that the generated URI's seem to work.

I don't think any of those actually specify the favicon... what does this return (with the right domain)?

Dec 8 2015, 12:01 AM · Installing & Upgrading

Dec 7 2015

epriestley added a comment to T9926: SVN Commit fails, hard to debug.

Are there any more details that might be useful?

Dec 7 2015, 11:56 PM · Bug Report (Needs Information), Subversion, Diffusion
epriestley added a revision to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter: Unknown Object (Differential Revision).
Dec 7 2015, 11:13 PM · ApplicationEditor
epriestley closed T5622: "copy" attribute for custom fields is not working, at least for text fields as Resolved by committing Restricted Diffusion Commit.
Dec 7 2015, 9:44 PM · Maniphest, Custom Fields