Page MenuHomePhabricator
Feed Advanced Search

Mar 7 2016

epriestley added a comment to T10517: Make Harbormaster build variables extensible.

If diffusion.search existed, you could call it with repository.phid to pull the short name, callsign, ID, etc. Would this be sufficient?

Mar 7 2016, 5:37 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

Also known as the far more hilarious CURLE_OPERATION_TIMEOUTED.

Mar 7 2016, 5:35 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

This may be cURL 28, CURLE_OPERATION_TIMEDOUT. We have a 60-second timeout on this build step. Is it possible your server requires more than 60s to acknowledge the initial request?

Mar 7 2016, 5:34 PM · Restricted Project, Harbormaster, Bug Report
epriestley renamed T10512: Implement `user.search` Conduit API method from conduit API to search for users based on roles to Implement `user.search` Conduit API method.
Mar 7 2016, 5:33 PM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley added a comment to T10520: Allow users to add other users as CC at countdown.

That is, it already supports subscribers, the field just never got built in the UI.

Mar 7 2016, 5:32 PM · Countdown, Feature Request
epriestley added a comment to T10520: Allow users to add other users as CC at countdown.

We probably will build this sooner or later since it's free when Countdown eventually swaps to EditEngine.

Mar 7 2016, 5:32 PM · Countdown, Feature Request
epriestley closed T10523: Herald Differential Diffs rule for "Added files". as Wontfix.

Sounds good. I'm going to close this out since we don't plan to pursue the particular rule it describes and I think other related work is already covered elsewhere.

Mar 7 2016, 5:30 PM · Restricted Project, Herald, Feature Request
epriestley added a comment to T10093: When builds fail because the staging area was not pushed, make the cause clear.

After D15427, this should be pretty clear for "Land Revision".

Mar 7 2016, 5:27 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley moved T6848: It should be possible to view a repository's policies without necessarily being able to edit it from Backlog to v3 on the Diffusion board.
Mar 7 2016, 5:24 PM · Diffusion (v3)
epriestley closed T6983: Best practices for repository creation as Resolved.

Importing SVN repositories as single repositories is recommended (Facebook's had several million commits in 2011, IIRC).

Mar 7 2016, 5:21 PM · Documentation, Diffusion
epriestley updated subscribers of T6848: It should be possible to view a repository's policies without necessarily being able to edit it.
Mar 7 2016, 5:19 PM · Diffusion (v3)
epriestley merged task T10534: No ability to view push permissions without edit rights. into T6848: It should be possible to view a repository's policies without necessarily being able to edit it.
Mar 7 2016, 5:19 PM · Diffusion, Feature Request
epriestley closed T5929: User copied a working copy over a Diffusion working copy and nothing worked anymore as Wontfix.

This hasn't happened again and I think it's less reasonable to expect it to work in modern Phabricator.

Mar 7 2016, 5:18 PM · Diffusion
epriestley added a comment to T3607: Diffusion should raise a reasonable error when the default branch does not exist.

I think this was resolved at some point -- this is the behavior at HEAD, which seems broadly reasonable:

Mar 7 2016, 5:17 PM · Diffusion
epriestley added a comment to T8612: Improve handling of "large" changesets.

See also T2225 for a concrete issue caused by showing enormous numbers of paths (unbearably slow page loads because of the raw wire filesize).

Mar 7 2016, 5:14 PM · Restricted Project, Performance, Differential
epriestley closed T2225: Render only the first 1,000 changed paths by default when viewing a commit in Diffusion as Resolved.

This was fixed a couple of years ago in D4730, and works fine on the modern LLVM install: http://reviews.llvm.org/rL170845

Mar 7 2016, 5:13 PM · Differential, Diffusion
epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Unknown Object (Differential Revision).
Mar 7 2016, 4:49 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Unknown Object (Differential Revision).
Mar 7 2016, 3:15 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a comment to T10093: When builds fail because the staging area was not pushed, make the cause clear.

After D15424, arc fails when failing to push the staging area.

Mar 7 2016, 2:55 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley closed T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote, a subtask of T8238: Formally support side-band change handoff in external repositories, as Resolved.
Mar 7 2016, 2:53 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley closed T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote as Resolved by committing Restricted Diffusion Commit.
Mar 7 2016, 2:53 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

I've marked D15424 as fixing this, although I don't have a detailed understanding of exactly what goes on in the git protocol and which heuristics it is using. In particular, I haven't been able to trick it into doing too much work locally (maybe it also looks at parents?).

Mar 7 2016, 2:53 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a revision to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote: Unknown Object (Differential Revision).
Mar 7 2016, 2:27 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley closed T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion. as Resolved.

This is on a daily cron, I think you missed the update by a couple of hours. Link works OK for me now.

Mar 7 2016, 1:28 PM · Diffusion, Differential, Bug Report
epriestley added a comment to T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery"..

Hi! How can we reproduce this behavior?

Mar 7 2016, 1:27 PM · Audit, Diffusion, Bug Report
epriestley closed T10531: Make workboard column headers into clickable links as Wontfix.

Please describe the root problem you're facing when requesting features. See Contributing Feature Requests and Describing Root Problems for details.

Mar 7 2016, 1:25 PM · Feature Request
epriestley closed T10532: Test 100 as Spite.
Mar 7 2016, 1:23 PM · Bug Report
dans awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Like token.
Mar 7 2016, 4:45 AM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley closed T10527: Almanac User Guide Typo as Resolved.
Mar 7 2016, 12:03 AM · Bug Report

Mar 6 2016

epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Unknown Object (Differential Revision).
Mar 6 2016, 11:37 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a revision to T6861: PHP sort function is unpredictable to human minds when dealing with mixed types: Unknown Object (Differential Revision).
Mar 6 2016, 3:57 PM · Infrastructure
featherless awarded T10038: Plan the mid-term pathway for unit-test/linter bindings a Like token.
Mar 6 2016, 2:46 AM · Lint, Arcanist

Mar 5 2016

epriestley closed T10519: no email sent for inline comments on a Diffusion commit as Resolved by committing Restricted Diffusion Commit.
Mar 5 2016, 10:18 PM · Mail, Diffusion, Bug Report
epriestley added a comment to T10519: no email sent for inline comments on a Diffusion commit.

Thanks for the report! This was a bug.

Mar 5 2016, 9:57 PM · Mail, Diffusion, Bug Report
epriestley claimed T10519: no email sent for inline comments on a Diffusion commit.
Mar 5 2016, 9:55 PM · Mail, Diffusion, Bug Report
epriestley added a revision to T10519: no email sent for inline comments on a Diffusion commit: Unknown Object (Differential Revision).
Mar 5 2016, 9:55 PM · Mail, Diffusion, Bug Report
epriestley added a comment to T10523: Herald Differential Diffs rule for "Added files"..

I believe this wouldn't solve your problem: I could add two files, A.c and B.c, and add a header to only one. This would pass the rule but fail what you intend to enforce, I think.

Mar 5 2016, 9:12 PM · Restricted Project, Herald, Feature Request
epriestley removed a member for Transactions: • Rockcena.
Mar 5 2016, 4:20 PM
epriestley removed a member for Transactions: joshuaspence.
Mar 5 2016, 4:20 PM
epriestley removed a member for Transactions: btrahan.
Mar 5 2016, 4:20 PM
epriestley removed a member for Transactions: • peter_england.
Mar 5 2016, 4:20 PM
epriestley removed a watcher for Transactions: • peter_england.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • peter_england.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: murphy.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • altman.jiri.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: joshuaspence.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • aderumier.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • vipinngupta15.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: epriestley.
Mar 5 2016, 4:19 PM
epriestley removed a watcher for Almanac: • Persona.
Mar 5 2016, 4:19 PM
epriestley removed a watcher for Almanac: • peter_england.
Mar 5 2016, 4:19 PM
epriestley added a comment to T10521: Properties table on Almanac bindings is a little out of wahck.

oh, you also have to put an interface on the device in order to bind it

Mar 5 2016, 4:19 PM · Almanac
epriestley added a comment to T10521: Properties table on Almanac bindings is a little out of wahck.

Create any device, create any service, bind the service to the device, then click "Details":

Mar 5 2016, 4:16 PM · Almanac
epriestley updated subscribers of T10246: Deploy Drydock in the Phacility cluster.

Drydock and Almanac are now available in the cluster. Here's a rough guide to configuring them -- I'll turn this into something formal once things work a little more smoothly.

Mar 5 2016, 3:41 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley created T10522: Build plan page doesn't warn about unapproved Drydock blueprints.
Mar 5 2016, 3:18 PM · Drydock, Restricted Project, Harbormaster (v3)
epriestley created T10521: Properties table on Almanac bindings is a little out of wahck.
Mar 5 2016, 2:58 PM · Almanac
Luke081515.2 awarded Blog Post: Development Notes (2016 Week 10) a Love token.
Mar 5 2016, 11:34 AM
epriestley edited the content of Changelog.
Mar 5 2016, 2:31 AM
epriestley created 2016 Week 10 (Early March).
Mar 5 2016, 2:31 AM
epriestley published Blog Post: Development Notes (2016 Week 10).
Mar 5 2016, 2:30 AM
epriestley created T10518: Adjustments to tags in HeaderView breaks workboard "point" tags.
Mar 5 2016, 2:03 AM · Workboards, Maniphest
epriestley closed T10449: Almanac v2 (Unprototype) as Resolved by committing Restricted Diffusion Commit.
Mar 5 2016, 1:22 AM · Almanac (v2), Phacility
epriestley closed T10449: Almanac v2 (Unprototype), a subtask of T10246: Deploy Drydock in the Phacility cluster, as Resolved.
Mar 5 2016, 1:22 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a revision to T10246: Deploy Drydock in the Phacility cluster: Unknown Object (Differential Revision).
Mar 5 2016, 1:19 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a revision to T10449: Almanac v2 (Unprototype): Unknown Object (Differential Revision).
Mar 5 2016, 12:45 AM · Almanac (v2), Phacility
epriestley added a revision to T10449: Almanac v2 (Unprototype): Unknown Object (Differential Revision).
Mar 5 2016, 12:26 AM · Almanac (v2), Phacility
epriestley added a revision to T10449: Almanac v2 (Unprototype): Unknown Object (Differential Revision).
Mar 5 2016, 12:21 AM · Almanac (v2), Phacility
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Yeah, that claim assumes someone will arc diff some published commit sooner or later (i.e., run arc diff while on master with no local changes). While this wouldn't happen on a normal workflow or on purpose, I suspect it happens more-often-than-never.

Mar 5 2016, 12:06 AM · Harbormaster (v3), Diffusion, Arcanist

Mar 4 2016

epriestley closed T10511: arc browse doesn't percent encode slashes in branch names as Resolved by committing Restricted Diffusion Commit.
Mar 4 2016, 11:53 PM · Arcanist, Bug Report
epriestley added a comment to T10511: arc browse doesn't percent encode slashes in branch names.

I think that'll fix it. Thanks for the report!

Mar 4 2016, 11:52 PM · Arcanist, Bug Report
epriestley claimed T10511: arc browse doesn't percent encode slashes in branch names.
Mar 4 2016, 11:52 PM · Arcanist, Bug Report
epriestley added a revision to T10511: arc browse doesn't percent encode slashes in branch names: Unknown Object (Differential Revision).
Mar 4 2016, 11:51 PM · Arcanist, Bug Report
epriestley closed T10513: Proposed Solution to Admin Control Paradox as Wontfix.

I can't recall any reports of those issues on other installs, and we haven't experienced them ourselves. I don't think these issues are typical, frequent, or widespread.

Mar 4 2016, 11:47 PM · Feature Request
epriestley added a comment to T10246: Deploy Drydock in the Phacility cluster.

Quick update here ahead of deployment tomorrow:

Mar 4 2016, 4:54 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley added a comment to T10513: Proposed Solution to Admin Control Paradox.

What are the specific things you want this feature for? Please describe the root problem you're facing. See Describing Root Problems for help.

Mar 4 2016, 4:27 PM · Feature Request
epriestley updated subscribers of T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist.
Mar 4 2016, 4:24 PM · Restricted Project, Differential
epriestley merged task T10515: If I have accepted a revision it still shows up as "blocking others" into T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist.
Mar 4 2016, 4:24 PM · Bug Report
trevorsummerssmith awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Mar 4 2016, 3:17 PM · Workboards (v3), Restricted Project
benjumanji awarded T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure a Like token.
Mar 4 2016, 9:23 AM · Restricted Project, Custom Fields, Diffusion
kristo.mario awarded T8783: Unprototype Nuance (v1) a Like token.
Mar 4 2016, 8:36 AM · Nuance, Restricted Project

Mar 3 2016

epriestley added a comment to T9124: Support uploading build log data via the Harbormaster API.

Given how frequently ANSI characters and similar occur in build logs, this probably doesn't make sense until after we have support for binary data on the API (T5955).

Mar 3 2016, 11:28 PM · Restricted Project, Harbormaster
epriestley added a parent task for T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings: T9124: Support uploading build log data via the Harbormaster API.
Mar 3 2016, 11:27 PM · Restricted Project, Auth, Conduit
epriestley added a subtask for T9124: Support uploading build log data via the Harbormaster API: T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
Mar 3 2016, 11:27 PM · Restricted Project, Harbormaster
epriestley closed T9123: Build Phabricator in Harbormaster (v2) as Resolved.

Upstream builds have been in production for some time. There's always more work to be done, but I don't think there's anything actionable left here that isn't covered elswhere.

Mar 3 2016, 11:26 PM · Prioritized, Harbormaster
epriestley closed T9123: Build Phabricator in Harbormaster (v2), a subtask of T9456: Evaluate upstream support for third-party build systems, as Resolved.
Mar 3 2016, 11:26 PM · Restricted Project, Harbormaster
epriestley closed T10024: Can't remove blueprint limit as Resolved by committing Restricted Diffusion Commit.
Mar 3 2016, 11:21 PM · Drydock (v3), Bug Report
epriestley closed T10024: Can't remove blueprint limit, a subtask of T10457: Improve Harbomaster/Drydock UI/UX before release, as Resolved.
Mar 3 2016, 11:21 PM · Harbormaster (v3), Drydock (v3), Phacility
epriestley added a comment to T3980: Support "Bind to External Thing" to define project membership.

Is the outcome of this task likely to be select a source for a given project where source might be manual, or ldap, or something custom?

Mar 3 2016, 10:05 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley added a comment to T8612: Improve handling of "large" changesets.

I don't intend to change that limit. I believe there is very little value in reviewing 1000+ file changes from the web UI, and that the 1K file limit is a reasonable one.

Mar 3 2016, 7:48 PM · Restricted Project, Performance, Differential
epriestley added a comment to T8612: Improve handling of "large" changesets.

That commit is changing more than 1,000 files.

Mar 3 2016, 7:24 PM · Restricted Project, Performance, Differential
epriestley added a comment to T8612: Improve handling of "large" changesets.

What about per file diff viewing it would hide them by default but add an option to each file that says show diff.

Mar 3 2016, 6:48 PM · Restricted Project, Performance, Differential
Beltran-rubo awarded T731: Allow revisions to have alternate acceptance conditions a Like token.
Mar 3 2016, 3:46 PM · Restricted Project, Restricted Project, Differential
epriestley closed T10474: Dashboard panel changes seem to think every edit creates whole text all over again as Resolved by committing Restricted Diffusion Commit.
Mar 3 2016, 3:35 PM · Dashboards (v2), Bug Report
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Yes, this should eliminate the need to sync/cron/do anything.

Mar 3 2016, 3:09 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley moved T9276: Display when builds happen with status somewhere handy, like the differential timeline from v2 to v3 on the Harbormaster board.
Mar 3 2016, 3:06 PM · Restricted Project, Harbormaster (v3), Differential
epriestley moved T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker from Backlog to v3 on the Harbormaster board.
Mar 3 2016, 3:06 PM · Restricted Project, Harbormaster (v3), Differential
epriestley moved T5821: Implement "Run Arc Unit" build step and support showing unit test results inside Harbormaster from v2 to v3 on the Harbormaster board.
Mar 3 2016, 3:05 PM · Restricted Project, Harbormaster (v3)
epriestley moved T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote from Backlog to v3 on the Harbormaster board.
Mar 3 2016, 2:58 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley created T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.
Mar 3 2016, 2:58 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley moved T9493: Formalize attributes on Drydock resources and leases from Future to v3 on the Drydock board.
Mar 3 2016, 2:52 PM · Restricted Project, Drydock (v3)