Page MenuHomePhabricator

If I have accepted a revision it still shows up as "blocking others"
Closed, DuplicatePublic

Description

This appears to be the case when another person has requested changes.
IMO this should not show up in my list of "blocking others" since I have given the OK.

Event Timeline

we have a project that I am a member of that we are using to ensure that one of our "owners" approves the cl. We do this by using herald to automatically add that project to the reviewers. The project is a blocking reviewer.

If this is not the correct way to ensure at least one person in a set of reviewers approves something please let me know how to do so.