Page MenuHomePhabricator
Create Task
Maniphest T3607

Diffusion should raise a reasonable error when the default branch does not exist
Closed, ResolvedPublic
Actions

Description

One repository overview page in diffusion throws a

Unhandled Exception ("ConduitException")
ERR-INVALID-COMMIT

This repository worked previously, but I didn't check it after I updated Phabricator both this past weekend and yesterday. All other repository overview pages are fine.

Revisions and Commits

rP Phabricator
ClosedD7429 Add an "importing" state to repositories and clean up the UI

Related Objects

Event Timeline

colegleason added a project: Diffusion.Jul 23 2013, 8:01 PM
colegleason added a subscriber: colegleason.
epriestley added subscribers: btrahan, epriestley.Jul 23 2013, 8:08 PM

This probably actually means "The default branch for this repository does not exist." -- e.g., it was trying to expand "master" to a commit hash and failed. Is that consistent with the repository as configured? We should certainly be more graceful about this.

colegleason added a comment.Jul 24 2013, 9:24 PM

Yes, the issue was I deleted the remote branch marked as default without realizing it.

epriestley triaged this task as Low priority.Jul 24 2013, 9:33 PM

Okay, cool. We should obviously improve this, but that sort of scenario should be rare. Thanks for the report!

epriestley added a subscriber: hlau.Jul 25 2013, 7:20 PM

◀ Merged tasks: T3616.

epriestley added a comment.Jul 25 2013, 7:21 PM

@hlau, is it possible you're hitting the same issue? (Repository configured with a "default branch" which does not exist.)

hlau added a comment.Jul 25 2013, 7:58 PM

Yes! By any chance the error message can give some hint about which branch is problematic?

epriestley added a comment.Jul 25 2013, 8:10 PM

Yeah, we'll fix the error message. Definitely not good right now.

epriestley edited this Maniphest Task.Oct 27 2013, 4:53 AM
epriestley added a comment.Oct 27 2013, 4:54 AM

D7429 improves this substantially, but doesn't quite resolve it.

epriestley renamed this task from 'ERR-INVALID-COMMIT' on /diffusion/NAME/ to Diffusion should raise a reasonable error when the default branch does not exist.Oct 27 2013, 4:54 AM
epriestley added a subscriber: Juje007.Oct 27 2013, 5:00 AM

◀ Merged tasks: T1165.

joshuaspence added a subscriber: joshuaspence.May 30 2015, 6:38 AM
chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 5:22 AM
epriestley added a comment.Mar 7 2016, 5:17 PM

I think this was resolved at some point -- this is the behavior at HEAD, which seems broadly reasonable:

Screen Shot 2016-03-07 at 9.16.23 AM.png (843×1 px, 125 KB)

In theory, we could show other branches, etc., but you should probably reconfigure the repository anyway.

epriestley closed this task as Resolved.May 10 2016, 2:26 PM
epriestley claimed this task.

This behavior seems reasonable at HEAD and we haven't seen other issues with it.

epriestley mentioned this in T12931: Fallback for incorrect default branch in Diffusion could be nicer.Jul 21 2017, 10:11 PM
Phabricator · Built by Phacility