Page MenuHomePhabricator

arc browse doesn't percent encode slashes in branch names
Closed, ResolvedPublic

Description

I just found out that arc browse takes a --branch argument, which is super awesome. When I use it to open a path in a branch that contains a slash, however (e.g. releases/42), the URI that Arcanist opens doesn't percent encode the branch name in the URL (e.g. https://phabricator.evand.org/diffusion/X/browse/releases/42/AppDelegate.m), so Diffusion throws an exception (e.g. Ref "releases" does not exist in this repository).

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley added a revision: Restricted Differential Revision.Mar 4 2016, 11:51 PM
epriestley triaged this task as Normal priority.

I think that'll fix it. Thanks for the report!

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Mar 4 2016, 11:53 PM
epriestley added a commit: Restricted Diffusion Commit.