Page MenuHomePhabricator
Create Task
Maniphest T10519

no email sent for inline comments on a Diffusion commit
Closed, ResolvedPublic
Actions

Description

This issue has been there for about a couple of months.

If we submit inline comments only on a diffusion commit, no email is sent (check https://secure.phabricator.com/mail/query/outbox/).
See {rHGTEST0e1f30ecdeca} and {rHGTESTa5d6d422f8b3}.

If we submit some text in the comment panel at the bottom of the commit page along with the inline comments, an email is sent.
See {rHGTEST3b70277d773b}

Is this an expected behavior or a bug? If this is expected, is there some configuration option to turn on email in this case?

Revisions and Commits

rP Phabricator
D15407rP0569919eab54 Fix some visibility issues with inline comments in Diffusion

Related Objects

Event Timeline

shuying created this task.Mar 5 2016, 7:10 AM
epriestley added a revision: D15407: Fix some visibility issues with inline comments in Diffusion.Mar 5 2016, 9:55 PM
epriestley claimed this task.Mar 5 2016, 9:55 PM
epriestley triaged this task as Normal priority.

Thanks for the report! This was a bug.

It looks like this was an unintended side-effect of D14853. We had some sketchy/fragile code for deciding when to hide transactions, and the change there triggered it to misbehave. I think D15407 should resolve it, by making the code more robust.

epriestley closed this task as Resolved by committing rP0569919eab54: Fix some visibility issues with inline comments in Diffusion.Mar 5 2016, 10:18 PM
epriestley added a commit: rP0569919eab54: Fix some visibility issues with inline comments in Diffusion.
Phabricator · Built by Phacility