Page MenuHomePhabricator

Dashboard panel changes seem to think every edit creates whole text all over again
Closed, ResolvedPublic

Description

https://phabricator.wikimedia.org/W1#3664 - I didn't actually edit the text... If you open the diff in 'Show Details', you see it thinks I set the existing text (as if it wasn't there before)

Revisions and Commits

Restricted Differential Revision

Event Timeline

This is real dumb, but I think it only creates a moderate inconvenience so I probably won't try to dig into it until we do the next iteration on dashboards.

I think it's not trivial to fix. Normally, this would just be a bad implementation of getCustomTransactionOldValue() with a missing break; or something in that vein, but that field is spooky CustomField magic.

epriestley edited projects, added Dashboards (v2); removed Dashboards.
epriestley added a revision: Restricted Differential Revision.Mar 3 2016, 1:47 PM

I accidentally stumbled across the root cause for this and I think the fix is a one-liner, so it should work better after D15391.

epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Mar 3 2016, 3:35 PM
epriestley added a commit: Restricted Diffusion Commit.