Page MenuHomePhabricator
Feed Advanced Search

Dec 29 2015

epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 29 2015, 12:45 PM · Projects (v3)
epriestley closed Q257: How to create project Milestones? as resolved.
Dec 29 2015, 11:58 AM · Maniphest
epriestley added Q257: How to create project Milestones? (Answer 292).
Dec 29 2015, 11:58 AM
epriestley closed T10064: Adding Custom Field as Invalid.

This does not describe a bug with Phabricator. See Contributing Bug Reports and Support Resources.

Dec 29 2015, 11:11 AM
epriestley closed T10065: test as Spite.
Dec 29 2015, 11:08 AM · Bug Report
epriestley added a comment to T10063: E-mail addresses are publicly exposed.

Actually, even GitHub exposes unrecognized email addresses directly in the page source, which is the same behavior we have:

Dec 29 2015, 3:59 AM · Diffusion, Bug Report
epriestley merged task T10062: Automaticaly add a task to a commit, if task was added to differential revision into T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Dec 29 2015, 3:49 AM · Maniphest, Differential, Arcanist
epriestley updated subscribers of T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Dec 29 2015, 3:49 AM · Maniphest
epriestley added a comment to T10061: Split the view policy into "space" and "visible to" line in forms.

Is this an actual problem you've experienced, or purely hypothetical?

Dec 29 2015, 3:48 AM · Maniphest, Spaces, Feature Request
epriestley closed T10063: E-mail addresses are publicly exposed as Wontfix.

I don't think this represents a real problem. This information is inherently public: pushing commits to a public repository makes this information public and easily retrievable by automated means.

Dec 29 2015, 3:40 AM · Diffusion, Bug Report

Dec 28 2015

Luke081515.2 awarded T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions a Love token.
Dec 28 2015, 11:45 PM · Maniphest, Herald
epriestley closed T10058: Cannot Archive Owners Package as Resolved by committing Restricted Diffusion Commit.
Dec 28 2015, 10:10 PM · Owners, Bug Report
joshuaspence added a project to T10057: Unhandled Exception on Tokens: Ponder.
Dec 28 2015, 9:37 PM · Ponder, Tokens, Bug Report
joshuaspence added a project to T10057: Unhandled Exception on Tokens: Tokens.
Dec 28 2015, 9:36 PM · Ponder, Tokens, Bug Report
epriestley claimed T10058: Cannot Archive Owners Package.
Dec 28 2015, 9:30 PM · Owners, Bug Report
epriestley added a revision to T10058: Cannot Archive Owners Package: Unknown Object (Differential Revision).
Dec 28 2015, 9:30 PM · Owners, Bug Report
epriestley closed T10057: Unhandled Exception on Tokens as Resolved by committing Restricted Diffusion Commit.
Dec 28 2015, 9:28 PM · Ponder, Tokens, Bug Report
epriestley claimed T10057: Unhandled Exception on Tokens.
Dec 28 2015, 9:01 PM · Ponder, Tokens, Bug Report
epriestley added a revision to T10057: Unhandled Exception on Tokens: Unknown Object (Differential Revision).
Dec 28 2015, 9:01 PM · Ponder, Tokens, Bug Report
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 28 2015, 8:53 PM · Projects (v3)
epriestley added a comment to T9897: Unbeta Feedback on Phame.

I also might take a crack at fixing "human language diffs", I think I can get something which is worlds better than what we do right now pretty quickly (even if it isn't perfect) and it would be nice to be able to be smarter all over the place about communicating description/title changes and tailoring things for typo fixes, spelling mistakes and other minor edits. I think this is something we can get groundwork in place for and then improve gradually without needing to do any big rewrites or anything.

Dec 28 2015, 8:29 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

The logic around what we send to blog subscribers is a little goofy right now, and sends them the entire post content on every update.

Dec 28 2015, 8:15 PM · Phame
epriestley added a comment to Blog Post: Development Notes (2015 Week 52).

Thanks, fixed.

Dec 28 2015, 8:10 PM
epriestley updated the post content for Blog Post: Development Notes (2015 Week 52).
Dec 28 2015, 8:10 PM
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 28 2015, 2:31 PM · Phame
epriestley updated the task description for T9897: Unbeta Feedback on Phame.
Dec 28 2015, 2:22 PM · Phame
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 28 2015, 2:21 PM · Phame
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 28 2015, 1:45 PM · Phame
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 28 2015, 12:05 PM · Phame
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 28 2015, 11:58 AM · Phame
epriestley added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Dec 28 2015, 11:52 AM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Definitely, let me get you a rough cut.

Dec 28 2015, 11:48 AM · Phame
mufid awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Dec 28 2015, 10:18 AM · Workboards (v3), Restricted Project

Dec 27 2015

epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 4:00 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 3:13 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 12:55 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 12:42 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 12:17 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 12:12 PM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 11:03 AM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 10:45 AM · Projects (v3)
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Dec 27 2015, 10:32 AM · Projects (v3)

Dec 26 2015

epriestley added a comment to T8399: Support Áçčềñṭ-Ḟøłɖǐṅg in typeaheads.

It may also make sense to fold accents when normalizing strings for ngram indexes.

Dec 26 2015, 11:21 PM · Typeahead
epriestley closed T8454: User approval not working as Resolved.

I think we fixed this elsewhere, yell if it's still an issue.

Dec 26 2015, 11:20 PM · People
epriestley closed T8532: Filesystem class need some test coverage as Resolved.

I tink at least some of this was added in, e.g., D14231.

Dec 26 2015, 11:19 PM · libphutil
epriestley closed T8578: Provide a way to remove things from the search index as Wontfix.

You can destroy the whole index, then reindex everything.

Dec 26 2015, 11:16 PM · Search
epriestley closed T8619: Unable to get phabricator to send mail (except ./bin/mail send-test) as Invalid.

We don't know how to reproduce this and haven't seen other reports.

Dec 26 2015, 11:11 PM
epriestley closed T8649: When unsubscribing from task via email, Phab mail notification said a comment was left, but none was as Resolved.

I'm not sure how to reproduce this (it didn't reproduce just now), and haven't seen any other instances of it or further reports. It's possible this was fixed earlier this year; we did some work on inbound mail around the time of this report.

Dec 26 2015, 11:09 PM · Notifications
epriestley added a comment to T8649: When unsubscribing from task via email, Phab mail notification said a comment was left, but none was.

(Test.)

Dec 26 2015, 11:07 PM · Notifications
epriestley closed T8668: The web interface should alert (show a config issue?) when there are fatal errors or exceptions in the daemon log as Wontfix.

We haven't seen requests for this from other installs and I don't particularly favor this mechanism. Prior alerts in this vein like "daemon and web config differ" have created a lot of noise and little value. T7338 should eventually provide more monitoring tools.

Dec 26 2015, 11:04 PM · Config, Daemons
epriestley renamed T9274: Lightbox cycles through both on-page images and Conpherence sidebar images from Image preview list shows images from Conpherence sidebar as well to Lightbox cycles through both on-page images and Conpherence sidebar images.
Dec 26 2015, 10:57 PM · Lightbox, Conpherence
epriestley closed T8991: Creating a Phurl URL should validate a URL as Wontfix.

I don't think we actually need, this at least for now. We can look at it again later if we get more feedback about users making these sorts of errors, but it seems unlikely (I think?) that a use would type google and expect it to work.

Dec 26 2015, 10:49 PM · Phurl
epriestley closed T8993: Shortcut to get current Phabricator URL as a Phurl URL as Wontfix.

Let's just wait for a stronger use case before building this, I think our URL construction has generally become much stronger since this idea was originally tossed around.

Dec 26 2015, 10:48 PM · Phurl
epriestley added a revision to T10004: ApplicationEditor Errata: Unknown Object (Differential Revision).
Dec 26 2015, 9:08 PM · ApplicationEditor
epriestley added a comment to T9994: Merge conflicts causes resources not being able to be released.

I don't want the error messages to just disappear since I worry that might be confusing, but I've added an option to dismiss errors once you're done with them in D14886:

Dec 26 2015, 8:40 PM · Drydock, Differential, Bug Report
epriestley added a revision to T9994: Merge conflicts causes resources not being able to be released: Unknown Object (Differential Revision).
Dec 26 2015, 8:35 PM · Drydock, Differential, Bug Report
epriestley updated the post content for Blog Post: Development Notes (2015 Week 52).
Dec 26 2015, 8:02 PM
epriestley updated the post content for Blog Post: Development Notes (2015 Week 52).
Dec 26 2015, 8:00 PM
epriestley updated the post content for Blog Post: Development Notes (2015 Week 52).
Dec 26 2015, 7:59 PM
epriestley closed T10056: תמיכה בככה וככה as Spite.
Dec 26 2015, 3:29 PM · Feature Request
epriestley edited the content of 2015 Week 52 (Late December).
Dec 26 2015, 2:40 PM
epriestley published Blog Post: Development Notes (2015 Week 52).
Dec 26 2015, 2:28 PM
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Couple of thoughts, not necessarily unbeta stuff:

Dec 26 2015, 12:19 PM · Phame
epriestley updated the task description for T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 26 2015, 11:24 AM · Maniphest, Installing & Upgrading
epriestley updated the task description for T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 26 2015, 11:23 AM · Maniphest, Installing & Upgrading
epriestley updated the task description for T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 26 2015, 11:22 AM · Maniphest, Installing & Upgrading
epriestley updated the task description for T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 26 2015, 11:21 AM · Maniphest, Installing & Upgrading
epriestley edited the content of Changelog.
Dec 26 2015, 11:18 AM
epriestley created 2015 Week 52 (Late December).
Dec 26 2015, 11:16 AM

Dec 25 2015

epriestley closed T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null as Resolved by committing Restricted Diffusion Commit.
Dec 25 2015, 3:41 PM · Paste, Infrastructure
epriestley closed T9967: Provide a more straightforward way to revoke SSH keys by finding and destroying the objects as Resolved.

Resolved by D14823.

Dec 25 2015, 3:40 PM · Auth, Feature Request
epriestley edited projects for T10018: Application transactions don't get avatars in the Recent Activity Feed, added: Bug Report; removed Feature Request.
Dec 25 2015, 3:40 PM · Bug Report, Feed
epriestley edited projects for T9937: During arc land harbormaster lint/unit, it is hard to remember the failure information from previous arc diff, added: Feature Request; removed Bug Report.
Dec 25 2015, 3:24 PM · Restricted Project, Feature Request, Harbormaster, Arcanist, Restricted Project
epriestley edited projects for T10046: Unable to unignore config issues, added: Feature Request; removed Bug Report.
Dec 25 2015, 3:23 PM · Restricted Project, Feature Request, Config
epriestley merged T7587: Consider allowing room/thread conversion into T8488: Remove "room" vs "message" distinction.
Dec 25 2015, 3:20 PM · Conpherence
epriestley merged task T7587: Consider allowing room/thread conversion into T8488: Remove "room" vs "message" distinction.
Dec 25 2015, 3:20 PM · Conpherence
epriestley added a comment to T7587: Consider allowing room/thread conversion.

I'm going to merge this into T8488 since I think we ended up just removing this distinction.

Dec 25 2015, 3:20 PM · Conpherence
epriestley renamed T6861: PHP sort function is unpredictable to human minds when dealing with mixed types from PHP sort function is non-deterministic when dealing with mixed types to PHP sort function is unpredictable to human minds when dealing with mixed types.
Dec 25 2015, 3:18 PM · Infrastructure
epriestley closed T8505: Extending testing functionality as Wontfix.

I'm just going to close this because it doesn't identify any specific problems and I don't want to build these things to deal with hypothetical problems.

Dec 25 2015, 3:16 PM · libphutil, Infrastructure
epriestley closed T8462: Move object destruction to taskmaster daemons as Wontfix.

I think it's good that destruction happens in the foreground, since I think this should be a very rare operation and errors should always be reported to the user. Users who want to background long destruction operations for some reason can use tools like screen.

Dec 25 2015, 3:03 PM · Infrastructure, Daemons
epriestley claimed T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.
Dec 25 2015, 2:40 PM · Paste, Infrastructure
epriestley added a revision to T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null: Unknown Object (Differential Revision).
Dec 25 2015, 2:37 PM · Paste, Infrastructure
joshuaspence added a project to T10052: Harbormaster events are not listed in the Feed application: Harbormaster.
Dec 25 2015, 12:13 PM · Harbormaster, Bug Report

Dec 24 2015

epriestley added a comment to T10055: Redesign Hovercards.

These are in good shape technically for whatever you want to throw at them.

Dec 24 2015, 9:21 PM · Restricted Project, Hovercards, Design
epriestley added a revision to T8980: Make hovecards activate for standard handle lists: Unknown Object (Differential Revision).
Dec 24 2015, 8:39 PM · Hovercards, Calendar
epriestley added a revision to T8980: Make hovecards activate for standard handle lists: Unknown Object (Differential Revision).
Dec 24 2015, 8:34 PM · Hovercards, Calendar
epriestley added a revision to T8980: Make hovecards activate for standard handle lists: Unknown Object (Differential Revision).
Dec 24 2015, 8:00 PM · Hovercards, Calendar
epriestley added a revision to T8980: Make hovecards activate for standard handle lists: Unknown Object (Differential Revision).
Dec 24 2015, 7:46 PM · Hovercards, Calendar
epriestley renamed T6642: Support column visibility filters on Workboards from Support deleting workboard columns to Support column visibility filters on Workboards.
Dec 24 2015, 6:57 PM · Workboards (v3)
epriestley added a comment to T6642: Support column visibility filters on Workboards.

Maybe a better approach would be to let you filter which columns are visible more flexibly. It sounds like all the existing use cases are arising because "hide" isn't being used to archive obsolete columns, but because it's being used to give workboards multiple states where each state has a different set of visible columns.

Dec 24 2015, 6:56 PM · Workboards (v3)
epriestley moved T10054: Define product direction for Project/Profile UIs from Backlog to Projects v3 on the Projects board.
Dec 24 2015, 6:48 PM · Projects
epriestley added a revision to T8980: Make hovecards activate for standard handle lists: Unknown Object (Differential Revision).
Dec 24 2015, 6:47 PM · Hovercards, Calendar
epriestley closed T6579: Display hovercards on Tokens in Typeaheads as Wontfix.

See T5403 into T7858. I don't think this makes sense after T4100 with "Browse" UIs. All requests for this are "distinguish between multiple similarly-named projects", which is better done via "Browse".

Dec 24 2015, 6:35 PM · Hovercards, PHUI
epriestley added a revision to T10032: Improve individual NUX states (application level): Unknown Object (Differential Revision).
Dec 24 2015, 6:33 PM · Modernization, NUX
epriestley added a comment to T10032: Improve individual NUX states (application level).

Oh, I was thinking this needed a whole pile of work (like, all of T9372) but I don't think it actually does. I'll take a look.

Dec 24 2015, 6:28 PM · Modernization, NUX
epriestley updated subscribers of T7858: Typeahead/Tokenizer Errata.
Dec 24 2015, 6:26 PM · Restricted Project, Typeahead
epriestley merged task T5403: Display more high-level info in project hovercards into T7858: Typeahead/Tokenizer Errata.
Dec 24 2015, 6:26 PM · Hovercards, Projects
epriestley added a comment to T5403: Display more high-level info in project hovercards.

The original request here seems to be for specific links to members and workboards from hovercards. I think it predates modern defaulting rules (i.e., clicking the tag now takes you to workboards for projects where they're in use) and we haven't seen other requests for this. I expect work adjacent to T10054 to continue giving us better behavior for clicking through. I don't understand the use case for frequently needing to access members quickly. I don't currently anticipate adding these links to hovercards.

Dec 24 2015, 6:26 PM · Hovercards, Projects
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Dec 24 2015, 6:22 PM · Restricted Project, Typeahead
epriestley added a comment to T10053: On branches, show buildable status of their commits; allow branches to be queried on.

Branches/tags ("RefCursors") have real PHIDs as of D14731, so that part is done, at least.

Dec 24 2015, 5:09 PM · Restricted Project, Diffusion, Harbormaster