Page MenuHomePhabricator
Create Task
Maniphest T8454

User approval not working
Closed, ResolvedPublic
Actions

Description

Just noticed this on my test install... I created a new user named test. Instead of seeing the "Waiting for approval" modal, I got the following error:

err.png (744×1 px, 39 KB)

Furthermore, /people/query/approval/ shows no results, even though the new user shows as "Needs Approval" on /people/query/active/.

Revisions and Commits

rP Phabricator
AuditedrPb4de79741ceb Fix a minor issue with the approval queue

Related Objects

Event Timeline

joshuaspence created this task.Jun 5 2015, 11:28 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: People.
joshuaspence added a subscriber: joshuaspence.
epriestley added a commit: rPb4de79741ceb: Fix a minor issue with the approval queue.Jun 6 2015, 1:39 PM
epriestley added a subscriber: epriestley.Jun 6 2015, 1:41 PM

On the second part, the condition for that query was wrong coming out of D13122: noDisabled changed to isDisabled, but the default value didn't get flipped.

rPb4de797 changes the true (only disabled users) to false (hide disabled users).

joshuaspence added a comment.Jun 7 2015, 11:02 AM

The approval queue is fixed, but it still doesn't log in the new user correctly:

Screenshot from 2015-06-07 21:02:06.png (744×1 px, 36 KB)

gabe added a subscriber: gabe.Jun 8 2015, 7:43 PM

Just out of curiosity are you using the "auth.email-domains" feature?

I had a similar issue last week that seemed to go away once I disabled the auth.email-domains checking. Not a solution, but it did allow me to register new accounts temporarily.

joshuaspence added a comment.Jun 10 2015, 11:02 AM

No, I'm not using auth.email-domains.

epriestley closed this task as Resolved.Dec 26 2015, 11:20 PM
epriestley claimed this task.

I think we fixed this elsewhere, yell if it's still an issue.

Phabricator · Built by Phacility